[geode] branch develop updated: GEODE-6479 and GEODE-6422: remove tests (#3271)

[heybales]

This is an automated email from the ASF dual-hosted git repository.

heybales pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/geode.git


The following commit(s) were added to refs/heads/develop by this push:
     new 252a47c  GEODE-6479 and GEODE-6422: remove tests (#3271)
252a47c is described below

commit 252a47c7eb63f74476c00df1e24843ccc5831ff7
Author: Helena Bales <hba...@pivotal.io>
AuthorDate: Wed Mar 6 15:09:17 2019 -0800

    GEODE-6479 and GEODE-6422: remove tests (#3271)
    
    Removing non-deterministic unit tests because unit tests should be
    deterministic, and the tests were testing test code, not product code.
---
 .../test/junit/rules/ConcurrencyRuleTest.java      | 35 ----------------------
 1 file changed, 35 deletions(-)

diff --git 
a/geode-junit/src/test/java/org/apache/geode/test/junit/rules/ConcurrencyRuleTest.java
 
b/geode-junit/src/test/java/org/apache/geode/test/junit/rules/ConcurrencyRuleTest.java
index 6f9620b..cf2d35f 100644
--- 
a/geode-junit/src/test/java/org/apache/geode/test/junit/rules/ConcurrencyRuleTest.java
+++ 
b/geode-junit/src/test/java/org/apache/geode/test/junit/rules/ConcurrencyRuleTest.java
@@ -25,7 +25,6 @@ import java.io.IOException;
 import java.time.Duration;
 import java.util.List;
 import java.util.concurrent.Callable;
-import java.util.concurrent.TimeUnit;
 import java.util.concurrent.TimeoutException;
 import java.util.concurrent.atomic.AtomicBoolean;
 import java.util.concurrent.atomic.AtomicInteger;
@@ -389,40 +388,6 @@ public class ConcurrencyRuleTest {
 
   @Test
   @Parameters({"EXECUTE_IN_SERIES", "EXECUTE_IN_PARALLEL"})
-  public void repeatForDuration(Execution execution) {
-    Duration duration = Duration.ofMillis(200);
-    this.iterations.set(0);
-
-    
concurrencyRule.add(callWithRetValAndRepeatCount).repeatForDuration(duration);
-    await("Execution respects given duration").atMost(2000, 
TimeUnit.MILLISECONDS)
-        .until(() -> {
-          execution.execute(concurrencyRule);
-          return true;
-        });
-    assertThat(iterations.get()).isGreaterThan(1);
-  }
-
-  @Test
-  @Parameters({"EXECUTE_IN_PARALLEL"})
-  public void repeatUntilValue(Execution execution) {
-    boolean expectedVal = true;
-
-    retVal.set(false); // reset in case it has already been used
-
-    concurrencyRule.setTimeout(Duration.ofSeconds(60));
-    
concurrencyRule.add(callWithEventuallyCorrectRetVal).repeatUntilValue(expectedVal);
-    concurrencyRule.add(() -> {
-      Thread.sleep(500);
-      retVal.set(true);
-      return null;
-    });
-    execution.execute(concurrencyRule);
-
-    assertThat(invoked.get()).isTrue();
-  }
-
-  @Test
-  @Parameters({"EXECUTE_IN_SERIES", "EXECUTE_IN_PARALLEL"})
   public void repeatUntilValue_throwsIfValueIsNeverTrue(Execution execution) {
     boolean expectedVal = true;