This is an automated email from the ASF dual-hosted git repository.
nnag pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/geode.git
The following commit(s) were added to refs/heads/develop by this push:
new 97e1d19 GEODE-7213: Initialization of arrays with size 0
97e1d19 is described below
commit 97e1d1907bde63fb0053f5605dbb1113a418e106
Author: Naburun Nag <[email protected]>
AuthorDate: Fri Jul 19 10:08:48 2019 -0700
GEODE-7213: Initialization of arrays with size 0
* Non zero size requirement for array initialization is not a
requirement post JDK6
* Zero size is considered more efficient.
* toArray(new T[0]) is considered faster, safer and contractually
cleaner.
---
.../org/apache/geode/admin/internal/DistributedSystemConfigImpl.java | 4 ++--
.../java/org/apache/geode/admin/internal/SystemMemberCacheImpl.java | 2 +-
.../main/java/org/apache/geode/admin/jmx/internal/AgentLauncher.java | 2 +-
.../java/org/apache/geode/admin/jmx/internal/DynamicManagedBean.java | 4 ++--
.../java/org/apache/geode/cache/query/internal/CompiledJunction.java | 2 +-
.../java/org/apache/geode/cache/query/internal/MethodDispatch.java | 2 +-
.../main/java/org/apache/geode/cache/query/internal/PathUtils.java | 2 +-
.../main/java/org/apache/geode/cache/query/internal/QCompiler.java | 2 +-
.../org/apache/geode/distributed/internal/DistributionConfig.java | 2 +-
.../org/apache/geode/distributed/internal/DistributionMessage.java | 2 +-
.../distributed/internal/InternalConfigurationPersistenceService.java | 2 +-
.../org/apache/geode/distributed/internal/locks/DLockGrantor.java | 2 +-
.../distributed/internal/locks/DLockRecoverGrantorProcessor.java | 2 +-
geode-core/src/main/java/org/apache/geode/internal/SystemAdmin.java | 4 ++--
.../main/java/org/apache/geode/internal/admin/StatAlertsManager.java | 4 ++--
.../src/main/java/org/apache/geode/internal/cache/DiskStoreImpl.java | 2 +-
.../java/org/apache/geode/internal/cache/InitialImageOperation.java | 2 +-
.../org/apache/geode/internal/cache/SearchLoadAndWriteProcessor.java | 4 ++--
.../src/main/java/org/apache/geode/internal/cache/TXManagerImpl.java | 2 +-
.../java/org/apache/geode/internal/cache/snapshot/SnapshotPacket.java | 2 +-
.../apache/geode/internal/cache/tier/InternalClientMembership.java | 2 +-
.../java/org/apache/geode/internal/cache/xmlcache/CacheXmlParser.java | 2 +-
.../src/main/java/org/apache/geode/internal/size/ObjectTraverser.java | 4 ++--
.../java/org/apache/geode/internal/statistics/StatArchiveReader.java | 2 +-
.../java/org/apache/geode/internal/statistics/StatisticsTypeXml.java | 4 ++--
.../src/main/java/org/apache/geode/internal/stats50/VMStats50.java | 2 +-
.../geode/management/internal/beans/DistributedSystemBridge.java | 4 ++--
.../org/apache/geode/management/internal/beans/RegionMBeanBridge.java | 2 +-
.../internal/cli/commands/lifecycle/StartJConsoleCommand.java | 2 +-
.../internal/cli/commands/lifecycle/StartJVisualVMCommand.java | 2 +-
.../management/internal/cli/commands/lifecycle/StartVsdCommand.java | 2 +-
.../management/internal/web/shell/support/HttpInvocationHandler.java | 2 +-
.../main/java/org/apache/geode/pdx/ReflectionBasedAutoSerializer.java | 2 +-
33 files changed, 41 insertions(+), 41 deletions(-)
diff --git
a/geode-core/src/main/java/org/apache/geode/admin/internal/DistributedSystemConfigImpl.java
b/geode-core/src/main/java/org/apache/geode/admin/internal/DistributedSystemConfigImpl.java
index c6a4d4e..926a027 100755
---
a/geode-core/src/main/java/org/apache/geode/admin/internal/DistributedSystemConfigImpl.java
+++
b/geode-core/src/main/java/org/apache/geode/admin/internal/DistributedSystemConfigImpl.java
@@ -799,13 +799,13 @@ public class DistributedSystemConfigImpl implements
DistributedSystemConfig {
@Override
public CacheServerConfig[] getCacheServerConfigs() {
return (CacheServerConfig[]) this.cacheServerConfigs
- .toArray(new CacheServerConfig[this.cacheServerConfigs.size()]);
+ .toArray(new CacheServerConfig[0]);
}
@Override
public CacheVmConfig[] getCacheVmConfigs() {
return (CacheVmConfig[]) this.cacheServerConfigs
- .toArray(new CacheVmConfig[this.cacheServerConfigs.size()]);
+ .toArray(new CacheVmConfig[0]);
}
/**
diff --git
a/geode-core/src/main/java/org/apache/geode/admin/internal/SystemMemberCacheImpl.java
b/geode-core/src/main/java/org/apache/geode/admin/internal/SystemMemberCacheImpl.java
index 757bf0d..001c9de 100644
---
a/geode-core/src/main/java/org/apache/geode/admin/internal/SystemMemberCacheImpl.java
+++
b/geode-core/src/main/java/org/apache/geode/admin/internal/SystemMemberCacheImpl.java
@@ -214,7 +214,7 @@ public class SystemMemberCacheImpl implements
SystemMemberCache {
for (int i = 0; i < stats.length; i++) {
statList.add(createStatistic(stats[i]));
}
- this.statistics = (Statistic[]) statList.toArray(new
Statistic[statList.size()]);
+ this.statistics = (Statistic[]) statList.toArray(new Statistic[0]);
}
private void updateStats() {
diff --git
a/geode-core/src/main/java/org/apache/geode/admin/jmx/internal/AgentLauncher.java
b/geode-core/src/main/java/org/apache/geode/admin/jmx/internal/AgentLauncher.java
index d92cf1e..e80d915 100644
---
a/geode-core/src/main/java/org/apache/geode/admin/jmx/internal/AgentLauncher.java
+++
b/geode-core/src/main/java/org/apache/geode/admin/jmx/internal/AgentLauncher.java
@@ -289,7 +289,7 @@ public class AgentLauncher {
commands.add(key + "=" + agentProps.get(key.toString()));
}
- return commands.toArray(new String[commands.size()]);
+ return commands.toArray(new String[0]);
}
private void printCommandLine(final String[] commandLine) {
diff --git
a/geode-core/src/main/java/org/apache/geode/admin/jmx/internal/DynamicManagedBean.java
b/geode-core/src/main/java/org/apache/geode/admin/jmx/internal/DynamicManagedBean.java
index 85b2b38..eea63f0 100755
---
a/geode-core/src/main/java/org/apache/geode/admin/jmx/internal/DynamicManagedBean.java
+++
b/geode-core/src/main/java/org/apache/geode/admin/jmx/internal/DynamicManagedBean.java
@@ -71,7 +71,7 @@ public class DynamicManagedBean extends
org.apache.commons.modeler.ManagedBean {
}
}
this.attributes =
- (AttributeInfo[]) attributesList.toArray(new
AttributeInfo[attributesList.size()]);
+ (AttributeInfo[]) attributesList.toArray(new AttributeInfo[0]);
/*
* super.info should be nulled out anytime the structure is changed,
such as altering the
@@ -103,7 +103,7 @@ public class DynamicManagedBean extends
org.apache.commons.modeler.ManagedBean {
}
}
this.operations =
- (OperationInfo[]) operationsList.toArray(new
OperationInfo[operationsList.size()]);
+ (OperationInfo[]) operationsList.toArray(new OperationInfo[0]);
/*
* super.info should be nulled out anytime the structure is changed,
such as altering the
diff --git
a/geode-core/src/main/java/org/apache/geode/cache/query/internal/CompiledJunction.java
b/geode-core/src/main/java/org/apache/geode/cache/query/internal/CompiledJunction.java
index 0dd8159..f7fcd5a 100644
---
a/geode-core/src/main/java/org/apache/geode/cache/query/internal/CompiledJunction.java
+++
b/geode-core/src/main/java/org/apache/geode/cache/query/internal/CompiledJunction.java
@@ -667,7 +667,7 @@ public class CompiledJunction extends AbstractCompiledValue
implements Negatable
if (listOrPosition instanceof List) {
List ops = (List) listOrPosition;
nullifiedFields += ops.size();
- CompiledValue operands[] = (CompiledValue[]) ops.toArray(new
CompiledValue[ops.size()]);
+ CompiledValue operands[] = (CompiledValue[]) ops.toArray(new
CompiledValue[0]);
rangeJunctions[numRangeJunctions++] =
new RangeJunction(this._operator, grpIndpndntItr,
completeExpnsn, operands);
}
diff --git
a/geode-core/src/main/java/org/apache/geode/cache/query/internal/MethodDispatch.java
b/geode-core/src/main/java/org/apache/geode/cache/query/internal/MethodDispatch.java
index 8da0a99..6584dc1 100644
---
a/geode-core/src/main/java/org/apache/geode/cache/query/internal/MethodDispatch.java
+++
b/geode-core/src/main/java/org/apache/geode/cache/query/internal/MethodDispatch.java
@@ -48,7 +48,7 @@ public class MethodDispatch {
String methodName, List argTypes) throws NameResolutionException {
_targetClass = targetClass;
_methodName = methodName;
- _argTypes = (Class[]) argTypes.toArray(new Class[argTypes.size()]);
+ _argTypes = (Class[]) argTypes.toArray(new Class[0]);
_methodInvocationAuthorizer = methodInvocationAuthorizer;
resolve();
diff --git
a/geode-core/src/main/java/org/apache/geode/cache/query/internal/PathUtils.java
b/geode-core/src/main/java/org/apache/geode/cache/query/internal/PathUtils.java
index 0fb3fed..7a5523a 100644
---
a/geode-core/src/main/java/org/apache/geode/cache/query/internal/PathUtils.java
+++
b/geode-core/src/main/java/org/apache/geode/cache/query/internal/PathUtils.java
@@ -47,7 +47,7 @@ public class PathUtils {
while (tokenizer.hasMoreTokens()) {
alist.add(tokenizer.nextToken());
}
- return (String[]) alist.toArray(new String[alist.size()]);
+ return (String[]) alist.toArray(new String[0]);
}
public static String buildPathString(String[] path) {
diff --git
a/geode-core/src/main/java/org/apache/geode/cache/query/internal/QCompiler.java
b/geode-core/src/main/java/org/apache/geode/cache/query/internal/QCompiler.java
index 594d8c3..65e94c7 100644
---
a/geode-core/src/main/java/org/apache/geode/cache/query/internal/QCompiler.java
+++
b/geode-core/src/main/java/org/apache/geode/cache/query/internal/QCompiler.java
@@ -563,7 +563,7 @@ public class QCompiler implements OQLLexerTokenTypes {
}
push(new CompiledJunction(
- (CompiledValue[]) operands.toArray(new
CompiledValue[operands.size()]), operator));
+ (CompiledValue[]) operands.toArray(new CompiledValue[0]), operator));
}
diff --git
a/geode-core/src/main/java/org/apache/geode/distributed/internal/DistributionConfig.java
b/geode-core/src/main/java/org/apache/geode/distributed/internal/DistributionConfig.java
index 2d21361..9ddcbde 100644
---
a/geode-core/src/main/java/org/apache/geode/distributed/internal/DistributionConfig.java
+++
b/geode-core/src/main/java/org/apache/geode/distributed/internal/DistributionConfig.java
@@ -5333,6 +5333,6 @@ public interface DistributionConfig extends Config,
LogConfig, StatisticsConfig
}
}
Collections.sort(atts);
- return atts.toArray(new String[atts.size()]);
+ return atts.toArray(new String[0]);
}
}
diff --git
a/geode-core/src/main/java/org/apache/geode/distributed/internal/DistributionMessage.java
b/geode-core/src/main/java/org/apache/geode/distributed/internal/DistributionMessage.java
index dfcd5ba..2c43935 100644
---
a/geode-core/src/main/java/org/apache/geode/distributed/internal/DistributionMessage.java
+++
b/geode-core/src/main/java/org/apache/geode/distributed/internal/DistributionMessage.java
@@ -253,7 +253,7 @@ public abstract class DistributionMessage implements
DataSerializableFixedID, Cl
"Recipients can only be set once");
}
this.recipients = recipients
- .toArray(new InternalDistributedMember[recipients.size()]);
+ .toArray(new InternalDistributedMember[0]);
}
public void resetRecipients() {
diff --git
a/geode-core/src/main/java/org/apache/geode/distributed/internal/InternalConfigurationPersistenceService.java
b/geode-core/src/main/java/org/apache/geode/distributed/internal/InternalConfigurationPersistenceService.java
index 42a6733..caae434 100644
---
a/geode-core/src/main/java/org/apache/geode/distributed/internal/InternalConfigurationPersistenceService.java
+++
b/geode-core/src/main/java/org/apache/geode/distributed/internal/InternalConfigurationPersistenceService.java
@@ -211,7 +211,7 @@ public class InternalConfigurationPersistenceService
implements ConfigurationPer
// No group is specified, so delete in every single group if it exists.
if (groups == null) {
Set<String> groupSet = configRegion.keySet();
- groups = groupSet.toArray(new String[groupSet.size()]);
+ groups = groupSet.toArray(new String[0]);
}
for (String group : groups) {
Configuration configuration = configRegion.get(group);
diff --git
a/geode-core/src/main/java/org/apache/geode/distributed/internal/locks/DLockGrantor.java
b/geode-core/src/main/java/org/apache/geode/distributed/internal/locks/DLockGrantor.java
index 6157e59..d1a0348 100644
---
a/geode-core/src/main/java/org/apache/geode/distributed/internal/locks/DLockGrantor.java
+++
b/geode-core/src/main/java/org/apache/geode/distributed/internal/locks/DLockGrantor.java
@@ -555,7 +555,7 @@ public class DLockGrantor {
batchList.add(batch);
}
}
- return (DLockBatch[]) batchList.toArray(new
DLockBatch[batchList.size()]);
+ return (DLockBatch[]) batchList.toArray(new DLockBatch[0]);
}
}
diff --git
a/geode-core/src/main/java/org/apache/geode/distributed/internal/locks/DLockRecoverGrantorProcessor.java
b/geode-core/src/main/java/org/apache/geode/distributed/internal/locks/DLockRecoverGrantorProcessor.java
index 487cc8c..188a861 100755
---
a/geode-core/src/main/java/org/apache/geode/distributed/internal/locks/DLockRecoverGrantorProcessor.java
+++
b/geode-core/src/main/java/org/apache/geode/distributed/internal/locks/DLockRecoverGrantorProcessor.java
@@ -419,7 +419,7 @@ public class DLockRecoverGrantorProcessor extends
ReplyProcessor21 {
replyCode = DLockRecoverGrantorReplyMessage.GRANTOR_DISPUTE;
} else {
heldLocks =
- (DLockRemoteToken[]) heldLockSet.toArray(new
DLockRemoteToken[heldLockSet.size()]);
+ (DLockRemoteToken[]) heldLockSet.toArray(new
DLockRemoteToken[0]);
}
}
} catch (RuntimeException e) {
diff --git
a/geode-core/src/main/java/org/apache/geode/internal/SystemAdmin.java
b/geode-core/src/main/java/org/apache/geode/internal/SystemAdmin.java
index 66034b6..a242b45 100644
--- a/geode-core/src/main/java/org/apache/geode/internal/SystemAdmin.java
+++ b/geode-core/src/main/java/org/apache/geode/internal/SystemAdmin.java
@@ -184,7 +184,7 @@ public class SystemAdmin {
}
cmdVec.add(hostnameForClientsOption);
- String[] cmd = (String[]) cmdVec.toArray(new String[cmdVec.size()]);
+ String[] cmd = (String[]) cmdVec.toArray(new String[0]);
// start with a fresh log each time
if (!logFile.delete() && logFile.exists()) {
@@ -1150,7 +1150,7 @@ public class SystemAdmin {
StatArchiveReader reader = null;
boolean interrupted = false;
try {
- reader = new StatArchiveReader((File[]) archiveNames.toArray(new
File[archiveNames.size()]),
+ reader = new StatArchiveReader((File[]) archiveNames.toArray(new
File[0]),
specs, !monitor);
// Runtime.getRuntime().gc(); System.out.println("DEBUG: heap size=" +
// (Runtime.getRuntime().totalMemory() -
Runtime.getRuntime().freeMemory()));
diff --git
a/geode-core/src/main/java/org/apache/geode/internal/admin/StatAlertsManager.java
b/geode-core/src/main/java/org/apache/geode/internal/admin/StatAlertsManager.java
index 0b7bdb7..fdd1012 100644
---
a/geode-core/src/main/java/org/apache/geode/internal/admin/StatAlertsManager.java
+++
b/geode-core/src/main/java/org/apache/geode/internal/admin/StatAlertsManager.java
@@ -250,7 +250,7 @@ public class StatAlertsManager {
}
} // while
} // synchronized
- return (StatAlert[]) alerts.toArray(new StatAlert[alerts.size()]);
+ return (StatAlert[]) alerts.toArray(new StatAlert[0]);
}
/**
@@ -312,7 +312,7 @@ public class StatAlertsManager {
}
} // for
- return (StatAlertDefinition[]) result.toArray(new
StatAlertDefinition[result.size()]);
+ return (StatAlertDefinition[]) result.toArray(new StatAlertDefinition[0]);
}
/**
diff --git
a/geode-core/src/main/java/org/apache/geode/internal/cache/DiskStoreImpl.java
b/geode-core/src/main/java/org/apache/geode/internal/cache/DiskStoreImpl.java
index ff8c4a6..e02c5ce 100644
---
a/geode-core/src/main/java/org/apache/geode/internal/cache/DiskStoreImpl.java
+++
b/geode-core/src/main/java/org/apache/geode/internal/cache/DiskStoreImpl.java
@@ -2779,7 +2779,7 @@ public class DiskStoreImpl implements DiskStore {
return null;
}
- return l.toArray(new CompactableOplog[l.size()]);
+ return l.toArray(new CompactableOplog[0]);
}
/**
diff --git
a/geode-core/src/main/java/org/apache/geode/internal/cache/InitialImageOperation.java
b/geode-core/src/main/java/org/apache/geode/internal/cache/InitialImageOperation.java
index f0035cc..710cfa5 100644
---
a/geode-core/src/main/java/org/apache/geode/internal/cache/InitialImageOperation.java
+++
b/geode-core/src/main/java/org/apache/geode/internal/cache/InitialImageOperation.java
@@ -738,7 +738,7 @@ public class InitialImageOperation {
// member(s) These will either be DistributedMember IDs or DiskStore
IDs
RequestSyncMessage msg = new RequestSyncMessage();
msg.regionPath = this.region.getFullPath();
- msg.lostVersionSources = needsSync.toArray(new
VersionSource[needsSync.size()]);
+ msg.lostVersionSources = needsSync.toArray(new VersionSource[0]);
Set recipients =
this.region.getCacheDistributionAdvisor().adviseReplicates();
for (Iterator it = recipients.iterator(); it.hasNext();) {
InternalDistributedMember mbr = (InternalDistributedMember)
it.next();
diff --git
a/geode-core/src/main/java/org/apache/geode/internal/cache/SearchLoadAndWriteProcessor.java
b/geode-core/src/main/java/org/apache/geode/internal/cache/SearchLoadAndWriteProcessor.java
index 444ac5e..7fccb5c 100755
---
a/geode-core/src/main/java/org/apache/geode/internal/cache/SearchLoadAndWriteProcessor.java
+++
b/geode-core/src/main/java/org/apache/geode/internal/cache/SearchLoadAndWriteProcessor.java
@@ -702,7 +702,7 @@ public class SearchLoadAndWriteProcessor implements
MembershipListener {
ArrayList list = new ArrayList(loadCandidatesSet);
Collections.shuffle(list);
InternalDistributedMember[] loadCandidates =
- (InternalDistributedMember[]) list.toArray(new
InternalDistributedMember[list.size()]);
+ (InternalDistributedMember[]) list.toArray(new
InternalDistributedMember[0]);
initRemainingTimeout();
RegionAttributes attrs = region.getAttributes();
@@ -922,7 +922,7 @@ public class SearchLoadAndWriteProcessor implements
MembershipListener {
ArrayList list = new ArrayList(writeCandidateSet);
Collections.shuffle(list);
InternalDistributedMember[] writeCandidates =
- (InternalDistributedMember[]) list.toArray(new
InternalDistributedMember[list.size()]);
+ (InternalDistributedMember[]) list.toArray(new
InternalDistributedMember[0]);
initRemainingTimeout();
int index = 0;
do {
diff --git
a/geode-core/src/main/java/org/apache/geode/internal/cache/TXManagerImpl.java
b/geode-core/src/main/java/org/apache/geode/internal/cache/TXManagerImpl.java
index 925fd92..1b1e20d 100644
---
a/geode-core/src/main/java/org/apache/geode/internal/cache/TXManagerImpl.java
+++
b/geode-core/src/main/java/org/apache/geode/internal/cache/TXManagerImpl.java
@@ -670,7 +670,7 @@ public class TXManagerImpl implements
CacheTransactionManager, MembershipListene
// After this, newly added TXStateProxy would not operate on the TXState.
this.closed = true;
- proxies = this.hostedTXStates.values().toArray(new
TXStateProxy[this.hostedTXStates.size()]);
+ proxies = this.hostedTXStates.values().toArray(new TXStateProxy[0]);
}
for (TXStateProxy proxy : proxies) {
diff --git
a/geode-core/src/main/java/org/apache/geode/internal/cache/snapshot/SnapshotPacket.java
b/geode-core/src/main/java/org/apache/geode/internal/cache/snapshot/SnapshotPacket.java
index 5a26be3..10af540 100644
---
a/geode-core/src/main/java/org/apache/geode/internal/cache/snapshot/SnapshotPacket.java
+++
b/geode-core/src/main/java/org/apache/geode/internal/cache/snapshot/SnapshotPacket.java
@@ -199,7 +199,7 @@ public class SnapshotPacket implements
DataSerializableFixedID {
this.windowId = windowId;
this.packetId = UUID.randomUUID().toString();
this.sender = sender;
- records = recs.toArray(new SnapshotRecord[recs.size()]);
+ records = recs.toArray(new SnapshotRecord[0]);
}
/**
diff --git
a/geode-core/src/main/java/org/apache/geode/internal/cache/tier/InternalClientMembership.java
b/geode-core/src/main/java/org/apache/geode/internal/cache/tier/InternalClientMembership.java
index 940121a..fd6c4e9 100644
---
a/geode-core/src/main/java/org/apache/geode/internal/cache/tier/InternalClientMembership.java
+++
b/geode-core/src/main/java/org/apache/geode/internal/cache/tier/InternalClientMembership.java
@@ -185,7 +185,7 @@ public class InternalClientMembership {
List<ClientMembershipListener> l = clientMembershipListeners; // volatile
fetch
// convert to an array
ClientMembershipListener[] listeners =
- (ClientMembershipListener[]) l.toArray(new
ClientMembershipListener[l.size()]);
+ (ClientMembershipListener[]) l.toArray(new
ClientMembershipListener[0]);
return listeners;
}
diff --git
a/geode-core/src/main/java/org/apache/geode/internal/cache/xmlcache/CacheXmlParser.java
b/geode-core/src/main/java/org/apache/geode/internal/cache/xmlcache/CacheXmlParser.java
index 4df4de5..3fc7bf4 100644
---
a/geode-core/src/main/java/org/apache/geode/internal/cache/xmlcache/CacheXmlParser.java
+++
b/geode-core/src/main/java/org/apache/geode/internal/cache/xmlcache/CacheXmlParser.java
@@ -1515,7 +1515,7 @@ public class CacheXmlParser extends CacheXml implements
ContentHandler {
ResumptionAction raction = ResumptionAction.fromName(raName);
MembershipAttributes ra = new MembershipAttributes(
- (String[]) roles.toArray(new String[roles.size()]), laction, raction);
+ (String[]) roles.toArray(new String[0]), laction, raction);
RegionAttributesCreation rattrs = (RegionAttributesCreation) stack.peek();
rattrs.setMembershipAttributes(ra);
}
diff --git
a/geode-core/src/main/java/org/apache/geode/internal/size/ObjectTraverser.java
b/geode-core/src/main/java/org/apache/geode/internal/size/ObjectTraverser.java
index 3b2e692..29295a6 100644
---
a/geode-core/src/main/java/org/apache/geode/internal/size/ObjectTraverser.java
+++
b/geode-core/src/main/java/org/apache/geode/internal/size/ObjectTraverser.java
@@ -126,8 +126,8 @@ public class ObjectTraverser {
clazz = clazz.getSuperclass();
}
- return new FieldSet(staticFields.toArray(new Field[staticFields.size()]),
- nonPrimativeFields.toArray(new Field[nonPrimativeFields.size()]));
+ return new FieldSet(staticFields.toArray(new Field[0]),
+ nonPrimativeFields.toArray(new Field[0]));
}
public interface Visitor {
diff --git
a/geode-core/src/main/java/org/apache/geode/internal/statistics/StatArchiveReader.java
b/geode-core/src/main/java/org/apache/geode/internal/statistics/StatArchiveReader.java
index 58bdc46..25670c3 100644
---
a/geode-core/src/main/java/org/apache/geode/internal/statistics/StatArchiveReader.java
+++
b/geode-core/src/main/java/org/apache/geode/internal/statistics/StatArchiveReader.java
@@ -714,7 +714,7 @@ public class StatArchiveReader implements
StatArchiveFormat, AutoCloseable {
* Creates a ComboValue by adding all the specified values together.
*/
ComboValue(List valueList) {
- this((StatValue[]) valueList.toArray(new StatValue[valueList.size()]));
+ this((StatValue[]) valueList.toArray(new StatValue[0]));
}
/**
diff --git
a/geode-core/src/main/java/org/apache/geode/internal/statistics/StatisticsTypeXml.java
b/geode-core/src/main/java/org/apache/geode/internal/statistics/StatisticsTypeXml.java
index d85eba1..f990975 100644
---
a/geode-core/src/main/java/org/apache/geode/internal/statistics/StatisticsTypeXml.java
+++
b/geode-core/src/main/java/org/apache/geode/internal/statistics/StatisticsTypeXml.java
@@ -161,7 +161,7 @@ public class StatisticsTypeXml implements EntityResolver,
ErrorHandler {
Element typeNode = (Element) typeNodes.item(i);
types.add(extractType(typeNode, statFactory));
}
- return (StatisticsType[]) types.toArray(new StatisticsType[types.size()]);
+ return (StatisticsType[]) types.toArray(new StatisticsType[0]);
}
/**
@@ -179,7 +179,7 @@ public class StatisticsTypeXml implements EntityResolver,
ErrorHandler {
stats.add(extractStat(statNode, statFactory));
}
StatisticDescriptor[] descriptors =
- (StatisticDescriptor[]) stats.toArray(new
StatisticDescriptor[stats.size()]);
+ (StatisticDescriptor[]) stats.toArray(new StatisticDescriptor[0]);
String description = "";
{
NodeList descriptionNodes = typeNode.getElementsByTagName("description");
diff --git
a/geode-core/src/main/java/org/apache/geode/internal/stats50/VMStats50.java
b/geode-core/src/main/java/org/apache/geode/internal/stats50/VMStats50.java
index 0c420d6..c7625cc 100644
--- a/geode-core/src/main/java/org/apache/geode/internal/stats50/VMStats50.java
+++ b/geode-core/src/main/java/org/apache/geode/internal/stats50/VMStats50.java
@@ -247,7 +247,7 @@ public class VMStats50 implements VMStatsContract {
sds.add(f.createLongGauge("fdsOpen", "Current number of open file
descriptors", "fds"));
}
vmType = f.createType("VMStats", "Stats available on a 1.5 java virtual
machine.",
- sds.toArray(new StatisticDescriptor[sds.size()]));
+ sds.toArray(new StatisticDescriptor[0]));
pendingFinalizationCountId = vmType.nameToId("pendingFinalization");
loadedClassesId = vmType.nameToId("loadedClasses");
unloadedClassesId = vmType.nameToId("unloadedClasses");
diff --git
a/geode-core/src/main/java/org/apache/geode/management/internal/beans/DistributedSystemBridge.java
b/geode-core/src/main/java/org/apache/geode/management/internal/beans/DistributedSystemBridge.java
index 6b0d7fb..6f13706 100644
---
a/geode-core/src/main/java/org/apache/geode/management/internal/beans/DistributedSystemBridge.java
+++
b/geode-core/src/main/java/org/apache/geode/management/internal/beans/DistributedSystemBridge.java
@@ -652,7 +652,7 @@ public class DistributedSystemBridge {
set.addAll(hostedLocators);
}
- return set.toArray(new String[set.size()]);
+ return set.toArray(new String[0]);
}
return ManagementConstants.NO_DATA_STRING;
}
@@ -832,7 +832,7 @@ public class DistributedSystemBridge {
listOfRegions.add(bridge.getName());
}
- return listOfRegions.toArray(new String[listOfRegions.size()]);
+ return listOfRegions.toArray(new String[0]);
}
/**
diff --git
a/geode-core/src/main/java/org/apache/geode/management/internal/beans/RegionMBeanBridge.java
b/geode-core/src/main/java/org/apache/geode/management/internal/beans/RegionMBeanBridge.java
index 8655446..f23f1ea 100644
---
a/geode-core/src/main/java/org/apache/geode/management/internal/beans/RegionMBeanBridge.java
+++
b/geode-core/src/main/java/org/apache/geode/management/internal/beans/RegionMBeanBridge.java
@@ -233,7 +233,7 @@ public class RegionMBeanBridge<K, V> {
for (Region<?, ?> region : subregions) {
subregionPaths.add(region.getFullPath());
}
- return subregionPaths.toArray(new String[subregionPaths.size()]);
+ return subregionPaths.toArray(new String[0]);
}
public RegionMBeanBridge(CachePerfStats cachePerfStats) {
diff --git
a/geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/lifecycle/StartJConsoleCommand.java
b/geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/lifecycle/StartJConsoleCommand.java
index bc1d4b9..8fc5a31 100644
---
a/geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/lifecycle/StartJConsoleCommand.java
+++
b/geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/lifecycle/StartJConsoleCommand.java
@@ -147,6 +147,6 @@ public class StartJConsoleCommand extends
OfflineGfshCommand {
}
}
- return commandLine.toArray(new String[commandLine.size()]);
+ return commandLine.toArray(new String[0]);
}
}
diff --git
a/geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/lifecycle/StartJVisualVMCommand.java
b/geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/lifecycle/StartJVisualVMCommand.java
index d206049..0b32338 100644
---
a/geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/lifecycle/StartJVisualVMCommand.java
+++
b/geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/lifecycle/StartJVisualVMCommand.java
@@ -80,6 +80,6 @@ public class StartJVisualVMCommand extends OfflineGfshCommand
{
}
}
- return commandLine.toArray(new String[commandLine.size()]);
+ return commandLine.toArray(new String[0]);
}
}
diff --git
a/geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/lifecycle/StartVsdCommand.java
b/geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/lifecycle/StartVsdCommand.java
index de8f3f4..08f15dd 100644
---
a/geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/lifecycle/StartVsdCommand.java
+++
b/geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/lifecycle/StartVsdCommand.java
@@ -84,7 +84,7 @@ public class StartVsdCommand extends OfflineGfshCommand {
commandLine.add(getPathToVsd());
commandLine.addAll(processStatisticsArchiveFiles(statisticsArchiveFilePathnames));
- return commandLine.toArray(new String[commandLine.size()]);
+ return commandLine.toArray(new String[0]);
}
protected String getPathToVsd() {
diff --git
a/geode-core/src/main/java/org/apache/geode/management/internal/web/shell/support/HttpInvocationHandler.java
b/geode-core/src/main/java/org/apache/geode/management/internal/web/shell/support/HttpInvocationHandler.java
index 3129376..4238664 100644
---
a/geode-core/src/main/java/org/apache/geode/management/internal/web/shell/support/HttpInvocationHandler.java
+++
b/geode-core/src/main/java/org/apache/geode/management/internal/web/shell/support/HttpInvocationHandler.java
@@ -84,7 +84,7 @@ public class HttpInvocationHandler implements
InvocationHandler {
return null;
}
- return signature.toArray(new String[signature.size()]);
+ return signature.toArray(new String[0]);
}
@Override
diff --git
a/geode-core/src/main/java/org/apache/geode/pdx/ReflectionBasedAutoSerializer.java
b/geode-core/src/main/java/org/apache/geode/pdx/ReflectionBasedAutoSerializer.java
index 2221e96..9740da9 100644
---
a/geode-core/src/main/java/org/apache/geode/pdx/ReflectionBasedAutoSerializer.java
+++
b/geode-core/src/main/java/org/apache/geode/pdx/ReflectionBasedAutoSerializer.java
@@ -120,7 +120,7 @@ public class ReflectionBasedAutoSerializer implements
PdxSerializer, Declarable
if (l == null) {
l = Collections.emptyList();
}
- return l.toArray(new String[l.size()]);
+ return l.toArray(new String[0]);
}
/**
