This is an automated email from the ASF dual-hosted git repository.

heybales pushed a commit to branch GEODE-7554
in repository https://gitbox.apache.org/repos/asf/geode-benchmarks.git

commit 8ca991a5b8eb6415dcb039b0e244df915f5dde93
Author: Helena A. Bales <[email protected]>
AuthorDate: Thu Dec 5 10:48:35 2019 -0800

    fix append to failed file
---
 .../src/main/java/org/apache/geode/perftest/analysis/Analyzer.java   | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git 
a/harness/src/main/java/org/apache/geode/perftest/analysis/Analyzer.java 
b/harness/src/main/java/org/apache/geode/perftest/analysis/Analyzer.java
index 3f92507..a9edb4f 100644
--- a/harness/src/main/java/org/apache/geode/perftest/analysis/Analyzer.java
+++ b/harness/src/main/java/org/apache/geode/perftest/analysis/Analyzer.java
@@ -72,7 +72,7 @@ public class Analyzer {
     benchmarkRunResult.writeResult(new PrintWriter(System.out));
     /* throw exc if failed? */
 
-    String errorFilePath = testResultArg + "/../failedTests";
+    String errorFilePath = testResultArg + "/../../failedTests";
     BufferedWriter writer = new BufferedWriter(new FileWriter(errorFilePath, 
true));
 
     boolean isSignificantlyBetter = false;
@@ -84,18 +84,19 @@ public class Analyzer {
         if (isNaN(probeResult.baseline) || isNaN(probeResult.test)) {
           errorMessage.append("BENCHMARK FAILED: 
").append(benchmarkResult.name)
               .append(" missing result file.\n");
+          writer.append(benchmarkResult.name + "\n");
         } else if (probeResult.description.equals("average latency")) {
           if (probeResult.getDifference() > 0) {
             isHighWaterCandidate = false;
             if (probeResult.getDifference() >= 0.05) {
               errorMessage.append("BENCHMARK FAILED: 
").append(benchmarkResult.name)
                   .append(" average latency is 5% worse than baseline.\n");
+              writer.append(benchmarkResult.name + "\n");
             }
           } else if (probeResult.getDifference() <= -0.5) {
             isSignificantlyBetter = true;
           }
         }
-        writer.append(benchmarkResult.name);
       }
     }
 

Reply via email to