[geode-kafka-connector] branch master updated: Static analyzer performance improvements.

[nnag]

This is an automated email from the ASF dual-hosted git repository.

nnag pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/geode-kafka-connector.git


The following commit(s) were added to refs/heads/master by this push:
     new 5d1ac78  Static analyzer performance improvements.
5d1ac78 is described below

commit 5d1ac78365074ab18c8f4683fcc01f099f15c7b0
Author: Naburun Nag <n...@cs.wisc.edu>
AuthorDate: Wed Feb 19 14:33:09 2020 -0800

    Static analyzer performance improvements.
---
 .../java/org/apache/geode/kafka/sink/GeodeKafkaSink.java     |  3 +--
 .../java/org/apache/geode/kafka/source/GeodeKafkaSource.java |  3 +--
 .../java/org/apache/geode/kafka/utilities/JavaProcess.java   | 12 +-----------
 3 files changed, 3 insertions(+), 15 deletions(-)

diff --git a/src/main/java/org/apache/geode/kafka/sink/GeodeKafkaSink.java 
b/src/main/java/org/apache/geode/kafka/sink/GeodeKafkaSink.java
index 2bdd99a..edf2f97 100644
--- a/src/main/java/org/apache/geode/kafka/sink/GeodeKafkaSink.java
+++ b/src/main/java/org/apache/geode/kafka/sink/GeodeKafkaSink.java
@@ -45,8 +45,7 @@ public class GeodeKafkaSink extends SinkConnector {
     // All tasks will build up the topic to regions map. A few might not use 
certain keys but we
     // have no control over partitioning in kafka and which tasks will fire
     for (int i = 0; i < maxTasks; i++) {
-      Map<String, String> taskProps = new HashMap<>();
-      taskProps.putAll(sharedProps);
+      Map<String, String> taskProps = new HashMap<>(sharedProps);
       taskProps.put(GeodeConnectorConfig.TASK_ID, "" + i);
       taskConfigs.add(taskProps);
     }
diff --git a/src/main/java/org/apache/geode/kafka/source/GeodeKafkaSource.java 
b/src/main/java/org/apache/geode/kafka/source/GeodeKafkaSource.java
index d2418fb..89054a6 100644
--- a/src/main/java/org/apache/geode/kafka/source/GeodeKafkaSource.java
+++ b/src/main/java/org/apache/geode/kafka/source/GeodeKafkaSource.java
@@ -49,8 +49,7 @@ public class GeodeKafkaSource extends SourceConnector {
     List<List<String>> bindingsPerTask = 
ConnectorUtils.groupPartitions(bindings, maxTasks);
 
     for (int i = 0; i < maxTasks; i++) {
-      Map<String, String> taskProps = new HashMap<>();
-      taskProps.putAll(sharedProps);
+      Map<String, String> taskProps = new HashMap<>(sharedProps);
       taskProps.put(GeodeConnectorConfig.TASK_ID, "" + i);
       taskProps.put(GeodeSourceConnectorConfig.CQS_TO_REGISTER,
           GeodeConnectorConfig.reconstructString(bindingsPerTask.get(i)));
diff --git a/src/test/java/org/apache/geode/kafka/utilities/JavaProcess.java 
b/src/test/java/org/apache/geode/kafka/utilities/JavaProcess.java
index 2d20244..cb66f84 100644
--- a/src/test/java/org/apache/geode/kafka/utilities/JavaProcess.java
+++ b/src/test/java/org/apache/geode/kafka/utilities/JavaProcess.java
@@ -37,23 +37,13 @@ public class JavaProcess {
     processBuilderCommand[1] = "-cp";
     processBuilderCommand[2] = classpath;
     processBuilderCommand[3] = className;
-    for (int i = 0; i < args.length; i++) {
-      processBuilderCommand[4 + i] = args[i];
-    }
+    System.arraycopy(args, 0, processBuilderCommand, 4, args.length);
     ProcessBuilder builder = new ProcessBuilder(
         processBuilderCommand);
 
     process = builder.inheritIO().start();
   }
 
-  private String convertArgsToString(String... args) {
-    String string = "";
-    for (String arg : args) {
-      string += arg;
-    }
-    return string;
-  }
-
   public void waitFor() throws InterruptedException {
     process.waitFor();
   }