[geode-benchmarks] branch sni updated: make SNI benchmark more like non-SNI one; readme

[burcham]

This is an automated email from the ASF dual-hosted git repository.

burcham pushed a commit to branch sni
in repository https://gitbox.apache.org/repos/asf/geode-benchmarks.git


The following commit(s) were added to refs/heads/sni by this push:
     new 69a204d  make SNI benchmark more like non-SNI one; readme
69a204d is described below

commit 69a204d783b70d7aae5a530e4cc60f46fbb322bc
Author: Bill Burcham <bburc...@pivotal.io>
AuthorDate: Tue May 19 09:50:16 2020 -0700

    make SNI benchmark more like non-SNI one; readme
---
 README.md                                              | 18 ++++++++++++++++++
 .../benchmark/tests/PartitionedPutBenchmarkSNI.java    |  3 ++-
 2 files changed, 20 insertions(+), 1 deletion(-)

diff --git a/README.md b/README.md
index 28f1661..69e6efb 100644
--- a/README.md
+++ b/README.md
@@ -147,3 +147,21 @@ public class PutTask extends BenchmarkDriverAdapter 
implements Serializable {
   }
 }
 ```
+
+## SNI
+
+To run a test with SNI we currently have to:
+
+`./run_tests.sh -t burcham --bb sni  -- -DwithSsl=true --tests 
*PartitionedPutBenchmark`
+
+We're limited to just that test because topology is not orthogonal to 
test&mdash;each test explicitly specifies its topology.
+
+Also we have to provide `-DwithSsl=true` for an SNI test even though no SNI 
test could work without TLS.
+
+### TODO for SNI
+* verify `StartSniProxy` runs on proxy node
+* set up SNI in `StartClient` task via `setPoolSocketFactory`
+* don't require operator to supply `-DwithSSL=true` when running SNI 
tests&mdash;have a `-Dsni` instead 
+* make topology orthogonal to tests so all tests can run with SNI
+* `./run_tests.sh` often seems to hang after benchmarks have completed, 
requiring operator to enter ^C to un-stick it
+
diff --git 
a/geode-benchmarks/src/main/java/org/apache/geode/benchmark/tests/PartitionedPutBenchmarkSNI.java
 
b/geode-benchmarks/src/main/java/org/apache/geode/benchmark/tests/PartitionedPutBenchmarkSNI.java
index 49568d8..4d3e809 100644
--- 
a/geode-benchmarks/src/main/java/org/apache/geode/benchmark/tests/PartitionedPutBenchmarkSNI.java
+++ 
b/geode-benchmarks/src/main/java/org/apache/geode/benchmark/tests/PartitionedPutBenchmarkSNI.java
@@ -27,6 +27,7 @@ import org.junit.jupiter.api.Test;
 import org.apache.geode.benchmark.LongRange;
 import org.apache.geode.benchmark.tasks.CreateClientProxyRegion;
 import org.apache.geode.benchmark.tasks.CreatePartitionedRegion;
+import org.apache.geode.benchmark.tasks.PrePopulateRegion;
 import org.apache.geode.benchmark.tasks.PrePopulateRegionLong;
 import org.apache.geode.benchmark.tasks.PutTask;
 import org.apache.geode.benchmark.topology.ClientServerTopologyWithSNIProxy;
@@ -59,7 +60,7 @@ public class PartitionedPutBenchmarkSNI implements 
PerformanceTest {
     ClientServerTopologyWithSNIProxy.configure(config);
     before(config, new CreatePartitionedRegion(), SERVER);
     before(config, new CreateClientProxyRegion(), CLIENT);
-    before(config, new PrePopulateRegionLong(keyRange), CLIENT);
+    before(config, new PrePopulateRegion(keyRange), CLIENT);
     workload(config, new PutTask(keyRange), CLIENT);
     return config;
   }