This is an automated email from the ASF dual-hosted git repository. bschuchardt pushed a commit to branch develop in repository https://gitbox.apache.org/repos/asf/geode.git
The following commit(s) were added to refs/heads/develop by this push: new 1bca728 GEODE-7489: DistributionArchUnitTest is running out of memory for some users (#5783) 1bca728 is described below commit 1bca72803df43184457c03fdde012139f99ea285 Author: Bruce Schuchardt <bschucha...@pivotal.io> AuthorDate: Tue Dec 1 08:05:07 2020 -0800 GEODE-7489: DistributionArchUnitTest is running out of memory for some users (#5783) CoreOnlyUsesMembershipAPIArchUnitTest already restricts use of the membership API to certain classes and does so in a way that avoids using too much memory. Consequently we're removing this test that needs upwards of 1.5gb of heap since it performs nearly the same test but for a specific class in the API package instead of the whole package. --- .../internal/DistributionArchUnitTest.java | 54 ---------------------- 1 file changed, 54 deletions(-) diff --git a/geode-core/src/integrationTest/java/org/apache/geode/distributed/internal/DistributionArchUnitTest.java b/geode-core/src/integrationTest/java/org/apache/geode/distributed/internal/DistributionArchUnitTest.java deleted file mode 100644 index 4d40157..0000000 --- a/geode-core/src/integrationTest/java/org/apache/geode/distributed/internal/DistributionArchUnitTest.java +++ /dev/null @@ -1,54 +0,0 @@ -/* - * Licensed to the Apache Software Foundation (ASF) under one or more contributor license - * agreements. See the NOTICE file distributed with this work for additional information regarding - * copyright ownership. The ASF licenses this file to You under the Apache License, Version 2.0 (the - * "License"); you may not use this file except in compliance with the License. You may obtain a - * copy of the License at - * - * http://www.apache.org/licenses/LICENSE-2.0 - * - * Unless required by applicable law or agreed to in writing, software distributed under the License - * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express - * or implied. See the License for the specific language governing permissions and limitations under - * the License. - */ -package org.apache.geode.distributed.internal; - -import static com.tngtech.archunit.core.domain.JavaClass.Predicates.resideInAPackage; -import static com.tngtech.archunit.core.domain.JavaClass.Predicates.type; -import static com.tngtech.archunit.lang.syntax.ArchRuleDefinition.classes; - -import com.tngtech.archunit.core.importer.ImportOption; -import com.tngtech.archunit.junit.AnalyzeClasses; -import com.tngtech.archunit.junit.ArchTest; -import com.tngtech.archunit.junit.ArchUnitRunner; -import com.tngtech.archunit.junit.CacheMode; -import com.tngtech.archunit.lang.ArchRule; -import org.junit.Ignore; -import org.junit.runner.RunWith; - -import org.apache.geode.distributed.internal.membership.MembershipJUnitTest; -import org.apache.geode.distributed.internal.membership.api.Membership; - -@RunWith(ArchUnitRunner.class) -@AnalyzeClasses(packages = "org.apache.geode", cacheMode = CacheMode.PER_CLASS, - importOptions = ImportOption.DoNotIncludeArchives.class) -@Ignore("Disabling until we can fix the memory usage of this test") -public class DistributionArchUnitTest { - - @ArchTest - public static final ArchRule membershipShouldOnlyBeAccessedThroughDistributionClass = classes() - .that(type(Membership.class)) - .should() - .onlyBeAccessed() - .byClassesThat(type(Distribution.class) - .or(type(MembershipJUnitTest.class)) // another integrationTest - .or(type(DistributionImpl.MyDCReceiver.class)) - .or(resideInAPackage("org.apache.geode.distributed.internal.membership.api..")) - .or(resideInAPackage("org.apache.geode.distributed.internal.membership.gms..")) - .or(resideInAPackage("org.apache.geode.internal.tcp..")) - .or(resideInAPackage("org.apache.geode.distributed.internal.direct..")) - .or(type(DistributionImpl.class)) - - ); -}