This is an automated email from the ASF dual-hosted git repository. upthewaterspout pushed a commit to branch feature/redis-performance-testing in repository https://gitbox.apache.org/repos/asf/geode.git
commit fced898950a9253edc62b85722dd5c322bdede5b Author: Jens Deppe <[email protected]> AuthorDate: Mon Mar 8 10:59:02 2021 -0800 Run everything directly on netty threads --- .../internal/netty/ExecutionHandlerContext.java | 22 ++++++++++++---------- 1 file changed, 12 insertions(+), 10 deletions(-) diff --git a/geode-redis/src/main/java/org/apache/geode/redis/internal/netty/ExecutionHandlerContext.java b/geode-redis/src/main/java/org/apache/geode/redis/internal/netty/ExecutionHandlerContext.java index 68e3811..56e0cd8 100644 --- a/geode-redis/src/main/java/org/apache/geode/redis/internal/netty/ExecutionHandlerContext.java +++ b/geode-redis/src/main/java/org/apache/geode/redis/internal/netty/ExecutionHandlerContext.java @@ -126,7 +126,7 @@ public class ExecutionHandlerContext extends ChannelInboundHandlerAdapter { this.hscanCursor = new BigInteger("0"); redisStats.addClient(); - backgroundExecutor.submit(this::processCommandQueue); + // backgroundExecutor.submit(this::processCommandQueue); } public ChannelFuture writeToChannel(RedisResponse response) { @@ -168,9 +168,11 @@ public class ExecutionHandlerContext extends ChannelInboundHandlerAdapter { public void channelRead(ChannelHandlerContext ctx, Object msg) throws Exception { Command command = (Command) msg; command.setChannelHandlerContext(ctx); - if (!channelInactive.get()) { - commandQueue.put(command); - } + + executeCommand(command); + // if (!channelInactive.get()) { + // commandQueue.put(command); + // } } /** @@ -304,12 +306,12 @@ public class ExecutionHandlerContext extends ChannelInboundHandlerAdapter { return; } - if (!getPubSub().findSubscriptionNames(getClient()).isEmpty()) { - if (!command.getCommandType().isAllowedWhileSubscribed()) { - writeToChannel(RedisResponse - .error("only (P)SUBSCRIBE / (P)UNSUBSCRIBE / PING / QUIT allowed in this context")); - } - } + // if (!getPubSub().findSubscriptionNames(getClient()).isEmpty()) { + // if (!command.getCommandType().isAllowedWhileSubscribed()) { + // writeToChannel(RedisResponse + // .error("only (P)SUBSCRIBE / (P)UNSUBSCRIBE / PING / QUIT allowed in this context")); + // } + // } final long start = redisStats.startCommand(); try {
