This is an automated email from the ASF dual-hosted git repository. jbarrett pushed a commit to branch develop in repository https://gitbox.apache.org/repos/asf/geode.git
commit 5d69c63302af92c31c1073f1e1e2512a1e6db4b3 Author: Jacob Barrett <[email protected]> AuthorDate: Thu May 20 14:56:40 2021 -0700 GEODE-6588: Cleanup RegisterInterestList66 --- .../cache/tier/sockets/command/RegisterInterestList66.java | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/RegisterInterestList66.java b/geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/RegisterInterestList66.java index cc5aad4..cfb918f 100644 --- a/geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/RegisterInterestList66.java +++ b/geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/RegisterInterestList66.java @@ -14,6 +14,8 @@ */ package org.apache.geode.internal.cache.tier.sockets.command; +import static org.apache.geode.util.internal.UncheckedUtils.uncheckedCast; + import java.io.IOException; import java.util.List; @@ -90,7 +92,7 @@ public class RegisterInterestList66 extends BaseCommand { } // region data policy byte[] regionDataPolicyPartBytes; - boolean serializeValues = false; + final boolean serializeValues; try { Part regionDataPolicyPart = clientMessage.getPart(clientMessage.getNumberOfParts() - 1); regionDataPolicyPartBytes = (byte[]) regionDataPolicyPart.getObject(); @@ -105,7 +107,7 @@ public class RegisterInterestList66 extends BaseCommand { partNumber = 3; Part list = clientMessage.getPart(partNumber); try { - keys = (List<Object>) list.getObject(); + keys = uncheckedCast(list.getObject()); numberOfKeys = keys.size(); } catch (Exception e) { writeChunkedException(clientMessage, e, serverConnection); @@ -133,14 +135,14 @@ public class RegisterInterestList66 extends BaseCommand { // Process the register interest request if (keys.isEmpty() || regionName == null) { - String errMessage = null; + final String errMessage; if (keys.isEmpty() && regionName == null) { errMessage = "The input list of keys is empty and the input region name is null for the register interest request."; } else if (keys.isEmpty()) { errMessage = "The input list of keys for the register interest request is empty."; - } else if (regionName == null) { + } else { errMessage = "The input region name for the register interest request is null."; } @@ -163,7 +165,7 @@ public class RegisterInterestList66 extends BaseCommand { if (!DynamicRegionFactory.regionIsDynamicRegionList(regionName)) { RegisterInterestOperationContext registerContext = authorizeRequest.registerInterestListAuthorize(regionName, keys, policy); - keys = (List<Object>) registerContext.getKey(); + keys = uncheckedCast(registerContext.getKey()); } } // Register interest
