[geode] branch develop updated: GEODE-9942: Include JUnit 5 tests in stress tests (#7256)

[dhemery]

This is an automated email from the ASF dual-hosted git repository.

dhemery pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/geode.git


The following commit(s) were added to refs/heads/develop by this push:
     new b2417ca  GEODE-9942: Include JUnit 5 tests in stress tests (#7256)
b2417ca is described below

commit b2417ca82b096beeb174e536edd29c37f360f8fd
Author: Dale Emery <dem...@vmware.com>
AuthorDate: Tue Jan 11 14:58:21 2022 -0800

    GEODE-9942: Include JUnit 5 tests in stress tests (#7256)
    
    PROBLEM
    
    JUnit 5 test classes need not be public. Indeed, IntelliJ's default
    inspections discourage making JUnit 5 classes public.
    
    `StressTestHelper` uses a `ClassGraph` to gather information about test
    classes. By default, the `ClassGraph` scans only public classes. So by
    default, the `ClassGraph` does not gather information about JUnit 5
    classes with non-public visibility.
    
    As a result, our stress test scripts do not run JUnit 5 tests.
    
    SOLUTION
    
    Call `ignoreClassVisibility()` to configure the `ClassGraph` to scan all
    classes, not just public ones.
    
    A few poorly-controlled, unsophisticated experiments (on a 2016 MacBook)
    show that this increases the scan duration from 3 seconds to 3.4
    seconds.
---
 .../src/main/java/org/apache/geode/test/util/StressNewTestHelper.java    | 1 +
 1 file changed, 1 insertion(+)

diff --git 
a/geode-junit/src/main/java/org/apache/geode/test/util/StressNewTestHelper.java 
b/geode-junit/src/main/java/org/apache/geode/test/util/StressNewTestHelper.java
index 2b36460..a60ba03 100644
--- 
a/geode-junit/src/main/java/org/apache/geode/test/util/StressNewTestHelper.java
+++ 
b/geode-junit/src/main/java/org/apache/geode/test/util/StressNewTestHelper.java
@@ -78,6 +78,7 @@ public class StressNewTestHelper {
     this.packageToScan = packageToScan;
     scanResult = new ClassGraph().whitelistPackages(packageToScan)
         .enableClassInfo()
+        .ignoreClassVisibility() // Because JUnit 5 tests can have default 
(non-public) visibility
         .enableAnnotationInfo().scan();
   }