Repository: incubator-geode Updated Branches: refs/heads/feature/GEODE-409 c6a4c414e -> e39b30874
GEODE-103: Increase timeout and improve assertion message Increase timeout waiting for process start. Improve assertion message to include tiemout in milliseconds. Project: http://git-wip-us.apache.org/repos/asf/incubator-geode/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-geode/commit/e39b3087 Tree: http://git-wip-us.apache.org/repos/asf/incubator-geode/tree/e39b3087 Diff: http://git-wip-us.apache.org/repos/asf/incubator-geode/diff/e39b3087 Branch: refs/heads/feature/GEODE-409 Commit: e39b30874961d7e7c9e225422c14179bf81a931e Parents: c6a4c41 Author: Kirk Lund <[email protected]> Authored: Mon Oct 19 11:42:30 2015 -0700 Committer: Kirk Lund <[email protected]> Committed: Mon Oct 19 11:42:30 2015 -0700 ---------------------------------------------------------------------- .../gemfire/internal/process/ProcessStreamReaderTestCase.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/incubator-geode/blob/e39b3087/gemfire-core/src/test/java/com/gemstone/gemfire/internal/process/ProcessStreamReaderTestCase.java ---------------------------------------------------------------------- diff --git a/gemfire-core/src/test/java/com/gemstone/gemfire/internal/process/ProcessStreamReaderTestCase.java b/gemfire-core/src/test/java/com/gemstone/gemfire/internal/process/ProcessStreamReaderTestCase.java index 0b26d33..1f9563f 100755 --- a/gemfire-core/src/test/java/com/gemstone/gemfire/internal/process/ProcessStreamReaderTestCase.java +++ b/gemfire-core/src/test/java/com/gemstone/gemfire/internal/process/ProcessStreamReaderTestCase.java @@ -27,7 +27,7 @@ public abstract class ProcessStreamReaderTestCase { protected static final int PROCESS_TIME_TO_LIVE = 3*500; /** Timeout to wait for a forked process to start */ - protected static final int WAIT_FOR_PROCESS_TO_START_TIMEOUT = 30*1000; + protected static final int WAIT_FOR_PROCESS_TO_START_TIMEOUT = 60*1000; /** Timeout to wait for a running process to die -- this keeps timing out so I'm increasing it very large */ protected static final int WAIT_FOR_PROCESS_TO_DIE_TIMEOUT = 5*60*1000; @@ -93,7 +93,7 @@ public abstract class ProcessStreamReaderTestCase { for (StopWatch time = new StopWatch(true); !done && time.elapsedTimeMillis() < timeout; done = (callable.call())) { Thread.sleep(interval); } - assertTrue(message, done); + assertTrue(message + " within timeout of " + timeout + " milliseconds", done); } protected static void assertEventuallyFalse(final String message, final Callable<Boolean> callable, final int timeout, final int interval) throws Exception { @@ -101,7 +101,7 @@ public abstract class ProcessStreamReaderTestCase { for (StopWatch time = new StopWatch(true); !done && time.elapsedTimeMillis() < timeout; done = (!callable.call())) { Thread.sleep(interval); } - assertTrue(message, done); + assertTrue(message + " within timeout of " + timeout + " milliseconds", done); } protected static void assertIsAlive(final Process process) {
