GEODE-347: Fixing another race condition in expectErrorAfterWaitTime Another test method in TopEntriesFunctionCollectorJUnitTest had this same race condition - notifying the other thread before setting the shared state.
Project: http://git-wip-us.apache.org/repos/asf/incubator-geode/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-geode/commit/74512e59 Tree: http://git-wip-us.apache.org/repos/asf/incubator-geode/tree/74512e59 Diff: http://git-wip-us.apache.org/repos/asf/incubator-geode/diff/74512e59 Branch: refs/heads/develop Commit: 74512e59b36127ea4a341ef488fd218d2b6779e6 Parents: dc3e8f7 Author: Dan Smith <[email protected]> Authored: Tue Sep 22 14:48:33 2015 -0700 Committer: Dan Smith <[email protected]> Committed: Tue Sep 22 14:49:28 2015 -0700 ---------------------------------------------------------------------- .../internal/distributed/TopEntriesFunctionCollectorJUnitTest.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/incubator-geode/blob/74512e59/gemfire-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/distributed/TopEntriesFunctionCollectorJUnitTest.java ---------------------------------------------------------------------- diff --git a/gemfire-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/distributed/TopEntriesFunctionCollectorJUnitTest.java b/gemfire-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/distributed/TopEntriesFunctionCollectorJUnitTest.java index 08993dd..c139e9f 100644 --- a/gemfire-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/distributed/TopEntriesFunctionCollectorJUnitTest.java +++ b/gemfire-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/distributed/TopEntriesFunctionCollectorJUnitTest.java @@ -166,8 +166,8 @@ public class TopEntriesFunctionCollectorJUnitTest { try { collector.getResult(10, TimeUnit.MILLISECONDS); } catch (FunctionException e) { - endGetResult.countDown(); exception.set(e); + endGetResult.countDown(); } } });
