comment
Project: http://git-wip-us.apache.org/repos/asf/incubator-geode/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-geode/commit/37c68060 Tree: http://git-wip-us.apache.org/repos/asf/incubator-geode/tree/37c68060 Diff: http://git-wip-us.apache.org/repos/asf/incubator-geode/diff/37c68060 Branch: refs/heads/feature/GEODE-1464 Commit: 37c680608835f7d4b25a10ec98cad1e1b4015d99 Parents: 89a48fe Author: Darrel Schneider <[email protected]> Authored: Thu Jun 2 10:51:10 2016 -0700 Committer: Darrel Schneider <[email protected]> Committed: Thu Jun 2 10:51:10 2016 -0700 ---------------------------------------------------------------------- .../com/gemstone/gemfire/internal/cache/DiskEntry.java | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/incubator-geode/blob/37c68060/geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DiskEntry.java ---------------------------------------------------------------------- diff --git a/geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DiskEntry.java b/geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DiskEntry.java index 65ae615..e731ef7 100644 --- a/geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DiskEntry.java +++ b/geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DiskEntry.java @@ -925,11 +925,7 @@ public interface DiskEntry extends RegionEntry { } else { //The new value in the entry needs to be set after the disk writing - // has succeeded. If not , for GemFireXD , it is possible that other thread - // may pick this transient value from region entry ( which for - //offheap will eventually be released ) as index key, - //given that this operation is bound to fail in case of - //disk access exception. + // has succeeded. //entry.setValueWithContext(region, newValue); // OFFHEAP newValue already prepared @@ -944,10 +940,7 @@ public interface DiskEntry extends RegionEntry { if (dr.isBackup()) { dr.testIsRecoveredAndClear(did); // fixes bug 41409 if (dr.isSync()) { - //In case of compression the value is being set first - // because atleast for now , GemFireXD does not support compression - // if and when it does support, this needs to be taken care of else - // we risk Bug 48965 + //In case of compression the value is being set first if (AbstractRegionEntry.isCompressible(dr, newValue)) { entry.setValueWithContext(region, newValue); // OFFHEAP newValue already prepared
