clee704 commented on code in PR #4834:
URL: https://github.com/apache/incubator-gluten/pull/4834#discussion_r1516423526
##########
backends-velox/src/main/scala/io/glutenproject/backendsapi/velox/MetricsApiImpl.scala:
##########
@@ -91,7 +91,6 @@ class MetricsApiImpl extends MetricsApi with Logging {
Map(
"rawInputRows" -> SQLMetrics.createMetric(sparkContext, "number of raw
input rows"),
"rawInputBytes" -> SQLMetrics.createSizeMetric(sparkContext, "number of
raw input bytes"),
- "outputRows" -> SQLMetrics.createMetric(sparkContext, "number of output
rows"),
Review Comment:
There's already numOutputRows at line 115
##########
backends-velox/src/main/scala/io/glutenproject/backendsapi/velox/MetricsApiImpl.scala:
##########
@@ -132,7 +131,6 @@ class MetricsApiImpl extends MetricsApi with Logging {
Map(
"rawInputRows" -> SQLMetrics.createMetric(sparkContext, "number of raw
input rows"),
"rawInputBytes" -> SQLMetrics.createSizeMetric(sparkContext, "number of
raw input bytes"),
- "outputRows" -> SQLMetrics.createMetric(sparkContext, "number of output
rows"),
Review Comment:
There's already numOutputRows at line 156
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
