zwangsheng commented on code in PR #4828:
URL: https://github.com/apache/incubator-gluten/pull/4828#discussion_r1517189310
##########
.github/workflows/velox_be.yml:
##########
@@ -631,3 +616,17 @@ jobs:
if: ${{ always() }}
run: |
$PATH_TO_GLUTEN_TE/$OS_IMAGE_NAME/gha/gha-checkout/clean.sh
+
+ upload-golden-file:
+ runs-on: velox-self-hosted
+ needs: [ubuntu2004-test-spark32, ubuntu2004-test-spark33,
ubuntu2004-test-spark34]
+ steps:
+ - name: Upload golden files
Review Comment:
Right, we should trigger this upload job when the previous job fail.
And according to [Github Action
Doc](https://docs.github.com/en/actions/learn-github-actions/expressions#failure),
we should add this condition on job instead of adding on each step.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
