taiyang-li commented on code in PR #4634:
URL: https://github.com/apache/incubator-gluten/pull/4634#discussion_r1519116582
##########
cpp-ch/local-engine/Storages/SubstraitSource/SubstraitFileSource.h:
##########
@@ -18,27 +18,25 @@
#include <Columns/IColumn.h>
#include <Core/Block.h>
-#include <Core/ColumnsWithTypeAndName.h>
#include <Core/Field.h>
-#include <Interpreters/Context.h>
#include <Processors/Chunk.h>
-#include <Processors/Executors/PullingPipelineExecutor.h>
-#include <Processors/ISource.h>
-#include <QueryPipeline/QueryPipeline.h>
+#include <Storages/Parquet/ColumnIndexFilter.h>
+#include <Storages/Parquet/VectorizedParquetRecordReader.h>
#include <Storages/SubstraitSource/FormatFile.h>
#include <Storages/SubstraitSource/ReadBufferBuilder.h>
-#include <Storages/SubstraitSource/SubstraitFileSourceStep.h>
#include <base/types.h>
-
namespace local_engine
{
class FileReaderWrapper
{
public:
- explicit FileReaderWrapper(FormatFilePtr file_) : file(file_) { }
+ explicit FileReaderWrapper(const FormatFilePtr & file_) : file(file_) { }
virtual ~FileReaderWrapper() = default;
virtual bool pull(DB::Chunk & chunk) = 0;
- virtual void applyKeyCondition(std::shared_ptr<const DB::KeyCondition>
/*key_condition*/) { }
+ virtual void
+ applyKeyCondition(const std::shared_ptr<const DB::KeyCondition> &
/*key_condition*/, const std::shared_ptr<ColumnIndexFilter> &)
Review Comment:
add a comment that ColumnIndexFilter is useless when local format is not
used, and key_condition is useless vice versa.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
