zjuwangg commented on code in PR #4872:
URL: https://github.com/apache/incubator-gluten/pull/4872#discussion_r1519228359
##########
cpp/core/jni/JniWrapper.cc:
##########
@@ -830,7 +830,8 @@ JNIEXPORT jlong JNICALL
Java_io_glutenproject_vectorized_ShuffleWriterJniWrapper
jint startPartitionId,
jint pushBufferMaxSize,
jobject partitionPusher,
- jstring partitionWriterTypeJstr) {
+ jstring partitionWriterTypeJstr,
+ jboolean sortBeforeRR) {
Review Comment:
It's possible, but we can leverage current design to eliminate the first
column and avoid the performance loss by providing extra project.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
