pan3793 commented on code in PR #4913:
URL: https://github.com/apache/incubator-gluten/pull/4913#discussion_r1524124707
##########
.github/workflows/velox_be.yml:
##########
@@ -450,11 +450,27 @@ jobs:
--local --preset=velox --benchmark-type=h --error-on-memleak
--off-heap-size=10g -s=1.0 --threads=16 --iterations=1 \
&& GLUTEN_IT_JVM_ARGS=-Xmx20G sbin/gluten-it.sh queries-compare \
--local --preset=velox --benchmark-type=ds --error-on-memleak
--off-heap-size=40g -s=10.0 --threads=32 --iterations=1'
- - name: TPC-H SF1.0 && TPC-DS SF10.0 Parquet local spark3.2 with Celeborn
+ - name: TPC-H SF1.0 && TPC-DS SF10.0 Parquet local spark3.2 with
Celeborn 0.4.0
run: |
$PATH_TO_GLUTEN_TE/$OS_IMAGE_NAME/gha/gha-checkout/exec.sh \
- 'wget
https://archive.apache.org/dist/incubator/celeborn/celeborn-0.3.0-incubating/apache-celeborn-0.3.0-incubating-bin.tgz
&& \
- tar xzf apache-celeborn-0.3.0-incubating-bin.tgz -C /opt/ && mv
/opt/apache-celeborn-0.3.0-incubating-bin /opt/celeborn && cd /opt/celeborn && \
+ 'wget
https://archive.apache.org/dist/incubator/celeborn/celeborn-0.4.0-incubating/apache-celeborn-0.4.0-incubating-bin.tgz
&& \
Review Comment:
CI only covers 0.3.2 and 0.4.0, what about 0.3.0 and 0.3.1? we actually have
breaking changes on the APIs that Gluten used in the 0.3.x serial
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
