marin-ma commented on code in PR #4872:
URL: https://github.com/apache/incubator-gluten/pull/4872#discussion_r1524289030
##########
gluten-ut/spark33/src/test/scala/org/apache/spark/sql/execution/GlutenReplaceHashWithSortAggSuite.scala:
##########
@@ -72,6 +72,7 @@ class GlutenReplaceHashWithSortAggSuite
| SORT BY key
|)
|GROUP BY key
+ |ORDER BY key
Review Comment:
Thanks. Please document in the code as this modification makes our test sql
different from the original one
https://github.com/apache/spark/blob/922f5f686dc72433a9028bbe471a35a5b84f2855/sql/core/src/test/scala/org/apache/spark/sql/execution/ReplaceHashWithSortAggSuite.scala#L61-L72
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
