ayushi-agarwal commented on issue #4836: URL: https://github.com/apache/incubator-gluten/issues/4836#issuecomment-1997183192
@JkSelf There are three functions, row_number, rank and dense_rank which are supported by WindowGroupLimit operator in spark. We can map row_number to TopNRowNumber but to support other two it would need more changes. There can be two approaches: 1. To convert this WindowGroupLimit to Window plus Filter node. This won't require any change in velox. 2. Modify TopNRowNumber or create two more operators to support rank and dense_rank. This would require change in velox. Want to know your input on this that which approach would be better? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
