PHILO-HE commented on code in PR #4954:
URL: https://github.com/apache/incubator-gluten/pull/4954#discussion_r1525907862
##########
backends-velox/src/main/scala/io/glutenproject/backendsapi/velox/SparkPlanExecApiImpl.scala:
##########
@@ -609,7 +609,9 @@ class SparkPlanExecApiImpl extends SparkPlanExecApi {
Seq(
Sig[HLLAdapter](ExpressionNames.APPROX_DISTINCT),
Sig[UDFExpression](ExpressionNames.UDF_PLACEHOLDER),
- Sig[NaNvl](ExpressionNames.NANVL))
+ Sig[NaNvl](ExpressionNames.NANVL),
+
Sig[MonotonicallyIncreasingID](ExpressionNames.MONOTONICALLY_INCREASING_ID)
Review Comment:
I think it is better to put this in `ExpressionMappings.scala`, considering
it is a common function, not specific to Velox backend.
Then, you may need to add some code in the below to let CH backend use
`DefaultValidator` for fallback (Otherwise, I guess CH CI will fail).
https://github.com/apache/incubator-gluten/blob/main/backends-clickhouse/src/main/scala/io/glutenproject/utils/CHExpressionUtil.scala#L178
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
