baibaichen commented on code in PR #4634:
URL: https://github.com/apache/incubator-gluten/pull/4634#discussion_r1528030862
##########
cpp-ch/local-engine/tests/CMakeLists.txt:
##########
@@ -54,19 +54,27 @@ if (ENABLE_TESTS)
message("local engine udf sources: ${local_engine_udf_sources}")
message("local engine function parser sources:
${local_engine_function_parser_sources}")
- add_executable(unit_tests_local_engine ${local_engine_gtest_sources}
${local_engine_udf_sources} ${local_engine_function_parser_sources})
+ add_executable(unit_tests_local_engine
+ gluten_test_util.cpp
+ ${local_engine_gtest_sources}
+ ${local_engine_udf_sources}
+ ${local_engine_function_parser_sources})
target_include_directories(unit_tests_local_engine PRIVATE
- ${GTEST_INCLUDE_DIRS}/include
- ${ClickHouse_SOURCE_DIR}/utils/extern-local_engine)
+ ${ClickHouse_SOURCE_DIR}/utils/extern-local_engine
+ ${CMAKE_CURRENT_SOURCE_DIR}
+ )
# no-unreachable-code for GTEST_SKIP
target_compile_options(unit_tests_local_engine PRIVATE
-Wno-unreachable-code)
target_link_libraries(unit_tests_local_engine PRIVATE
gluten_clickhouse_backend_libs clickhouse_parsers loggers ch_contrib::gmock_all
ch_contrib::gtest)
- #TODO: target_link_libraries(unit_tests_local_engine PRIVATE ch_parquet)
-else()
+ target_link_libraries(unit_tests_local_engine PRIVATE ch_parquet)
+endif()
+
+if (ENABLE_BENCHMARKS)
include_directories(benchmark_local_engine SYSTEM PUBLIC
Review Comment:
this pr fix the build
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
