ulysses-you commented on code in PR #4996:
URL: https://github.com/apache/incubator-gluten/pull/4996#discussion_r1528459100
##########
backends-velox/src/main/scala/io/glutenproject/execution/RowToVeloxColumnarExec.scala:
##########
@@ -47,7 +48,7 @@ case class RowToVeloxColumnarExec(child: SparkPlan) extends
RowToColumnarExecBas
override def doExecuteColumnarInternal(): RDD[ColumnarBatch] = {
BackendsApiManager.getValidatorApiInstance.doSchemaValidate(schema).foreach {
reason =>
- throw new UnsupportedOperationException(
+ throw new GlutenException(
Review Comment:
`GlutenNotSupportException` ?
##########
gluten-core/src/main/scala/io/glutenproject/extension/columnar/TransformHintRule.scala:
##########
@@ -737,11 +738,14 @@ case class AddTransformHintRule() extends Rule[SparkPlan]
{
// Currently we assume a plan to be transformable by default.
}
} catch {
- case e: UnsupportedOperationException =>
+ case e @ (_: GlutenNotSupportException | _:
UnsupportedOperationException) =>
Review Comment:
shall we remove `UnsupportedOperationException` ?
##########
backends-velox/src/main/scala/io/glutenproject/execution/HashAggregateExecTransformer.scala:
##########
@@ -369,7 +370,7 @@ abstract class HashAggregateExecTransformer(
exprNodes.addAll(childNodes)
case _: HyperLogLogPlusPlus if aggFunc.aggBufferAttributes.size != 1 =>
- throw new UnsupportedOperationException("Only one input attribute is
expected.")
+ throw new GlutenException("Only one input attribute is expected.")
Review Comment:
`GlutenNotSupportException` ?
##########
gluten-core/src/main/scala/io/glutenproject/GlutenPlugin.scala:
##########
@@ -144,7 +145,7 @@ private[glutenproject] class GlutenDriverPlugin extends
DriverPlugin with Loggin
// off-heap bytes
if (!conf.contains(GlutenConfig.GLUTEN_OFFHEAP_SIZE_KEY)) {
- throw new
UnsupportedOperationException(s"${GlutenConfig.GLUTEN_OFFHEAP_SIZE_KEY} is not
set")
+ throw new GlutenException(s"${GlutenConfig.GLUTEN_OFFHEAP_SIZE_KEY} is
not set")
Review Comment:
`GlutenNotSupportException` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
