baibaichen commented on code in PR #4634:
URL: https://github.com/apache/incubator-gluten/pull/4634#discussion_r1529570876
##########
cpp-ch/local-engine/Parser/CHColumnToSparkRow.cpp:
##########
@@ -809,8 +809,11 @@ int64_t VariableLengthDataWriter::writeStruct(size_t
row_idx, const DB::Tuple &
writer.unsafeWrite(reinterpret_cast<const char *>(&v),
buffer_address + offset + start + len_null_bitmap + i * 8);
}
else
- writer.unsafeWrite(
- reinterpret_cast<const char *>(&field_value.get<char>()),
buffer_address + offset + start + len_null_bitmap + i * 8);
+ {
+ const char * src = writer.getWhichDataType().isFloat64() ?
reinterpret_cast<const char *>(&field_value.get<Float64>())
Review Comment:
add https://github.com/apache/incubator-gluten/issues/5009 for tracking this
issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
