zwangsheng commented on issue #4896: URL: https://github.com/apache/incubator-gluten/issues/4896#issuecomment-2006022282
> `ParquetFileFormat.scala` was ported from Spark code with a few code changes that overwrite Spark's logic. Maybe, we have to maintain two such files respectively for 3.3.1 & 3.3.4 in shims module to support the both versions. Can we just keep using 3.3.1 UTs in Gluten? Assume most UTs are shared by 3.3.1 & 3.3.4. Maybe, we can just extract some important UTs ( not covered in 3.3.1) from spark-3.3.4 and put into a new test module in gluten. I see. I will give a try to maintain two files. And go deep to find the difference. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
