zzcclp commented on code in PR #5019:
URL: https://github.com/apache/incubator-gluten/pull/5019#discussion_r1530038437
##########
backends-clickhouse/src/main/scala/org/apache/spark/sql/execution/datasources/v1/CHMergeTreeWriterInjects.scala:
##########
@@ -83,11 +86,14 @@ class CHMergeTreeWriterInjects extends
GlutenFormatWriterInjectsBase {
tableName,
orderByKeyOption,
lowCardKeyOption,
+ minmaxIndexKeyOption,
+ bfIndexKeyOption,
+ setIndexKeyOption,
primaryKeyOption,
partitionColumns,
ConverterUtils.convertNamedStructJson(tableSchema),
clickhouseTableConfigs,
- dataSchema
+ tableSchema.toAttributes // use table schema instead of data schema
Review Comment:
does it make sure that the `dataSchema` is the same as the tableSchema,
especially the nullable property?
If yes, can remove the dataSchema parameter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
