This is an automated email from the ASF dual-hosted git repository.
yuanzhou pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git
The following commit(s) were added to refs/heads/main by this push:
new 01cce51dd [VL] Update clang-format version to v4.11.0 for Velox
backend (#5035)
01cce51dd is described below
commit 01cce51dda6ecbce17449b5e8f5d01ae90b7779d
Author: Yan Ma <[email protected]>
AuthorDate: Wed Mar 20 08:56:03 2024 +0800
[VL] Update clang-format version to v4.11.0 for Velox backend (#5035)
* update clang-format version to v4.11.0 for Velox backend
* fix format check failures
---
.github/workflows/code_style.yml | 4 ++--
cpp/velox/substrait/SubstraitToVeloxExpr.cc | 3 ++-
2 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/.github/workflows/code_style.yml b/.github/workflows/code_style.yml
index e93279075..f1c9c2548 100644
--- a/.github/workflows/code_style.yml
+++ b/.github/workflows/code_style.yml
@@ -36,9 +36,9 @@ jobs:
steps:
- uses: actions/checkout@v4
- name: Run clang-format style check for C/C++ programs.
- uses: jidicula/[email protected]
+ uses: jidicula/[email protected]
with:
- clang-format-version: '12'
+ clang-format-version: '15'
check-path: ${{ matrix.path['check'] }}
fallback-style: 'Google' # optional
diff --git a/cpp/velox/substrait/SubstraitToVeloxExpr.cc
b/cpp/velox/substrait/SubstraitToVeloxExpr.cc
index fd68be16e..f795f9c9e 100644
--- a/cpp/velox/substrait/SubstraitToVeloxExpr.cc
+++ b/cpp/velox/substrait/SubstraitToVeloxExpr.cc
@@ -420,7 +420,8 @@ VectorPtr SubstraitVeloxExprConverter::literalsToVector(
case ::substrait::Expression_Literal::LiteralTypeCase::kNull: {
auto veloxType = SubstraitParser::parseType(childLiteral.null());
auto kind = veloxType->kind();
- return VELOX_DYNAMIC_SCALAR_TYPE_DISPATCH_ALL(constructFlatVector, kind,
elementAtFunc, childSize, veloxType, pool_);
+ return VELOX_DYNAMIC_SCALAR_TYPE_DISPATCH_ALL(
+ constructFlatVector, kind, elementAtFunc, childSize, veloxType,
pool_);
}
case
::substrait::Expression_Literal::LiteralTypeCase::kIntervalDayToSecond:
return constructFlatVector<TypeKind::BIGINT>(elementAtFunc, childSize,
INTERVAL_DAY_TIME(), pool_);
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
