marin-ma commented on code in PR #4952:
URL: https://github.com/apache/incubator-gluten/pull/4952#discussion_r1531482873


##########
backends-clickhouse/src/main/scala/io/glutenproject/backendsapi/clickhouse/CHSparkPlanExecApi.scala:
##########
@@ -750,4 +750,8 @@ class CHSparkPlanExecApi extends SparkPlanExecApi {
   ): GenerateExecTransformerBase = {
     CHGenerateExecTransformer(generator, requiredChildOutput, outer, 
generatorOutput, child)
   }
+
+  override def genPreProjectForGenerate(generate: GenerateExec): SparkPlan = 
generate

Review Comment:
   `GenerateExec` was initially implemented for CH, and they should have the 
native implementation for the generator expressions. Please check 
https://github.com/apache/incubator-gluten/pull/574
   
   Velox backend does not have the native function implementation to the 
generator expressions. But it has an `UnnestNode` operator that can help to 
generate the expected output. That's why a pre/post projection is added to 
adopt the input/output for the `UnnestNode`.
   
   I believe CH doesn't require the pre/post project logic for the supported 
generator. cc @taiyang-li 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to