FelixYBW commented on PR #5032: URL: https://github.com/apache/incubator-gluten/pull/5032#issuecomment-2010942586
Thank you. It's something we just planed. Since build_velox is always needed, can you add one flag like -Dfetch_velox=ON/OFF which can fetch velox or not before build? by default let's set it ON. We may also check if velox is fetched if not it always fetch. Another issue is that currently script skip the velox build even if we modified some file in velox because it check the commit id to continue. So we need a git commit --amend in velox dir to force to build. Is there any better way to build velox automatically? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
