zhztheplayer opened a new pull request, #5058:
URL: https://github.com/apache/incubator-gluten/pull/5058

   See proposal https://github.com/apache/incubator-gluten/issues/5057
   
   This is the first runnable version of ACBO with TPCH SF 1.0 and TPCDS 10.0 
passed.
   
   After this patch, one could set `spark.gluten.sql.advanced.cbo.enabled=true` 
to enable ACBO. It's by default disabled.
   
   Issues: 
   
   1. It's now only replacing `TransformPreOverrides()` with a rough cost model 
to do fallback;
   2. It's not tested with CH backend yet. @baibaichen @zzcclp If you would 
like to evaluate it for CH; Otherwise I could disable it for CH in next patch;
   3. It may generates slow plan since some operators like aggregation are not 
considered in ACBO. The side-effect of this will be amplified in performance 
test;
   4. The first version would only be **runnable**. Further integration works 
are required to make it ready for production.
   
   The following improvements are on the way:
   
   1. Enable group mutation (for ops like AQEShuffleReadExec which could 
propagate children's convention to parent);
   2. Enable pattern based rule-matching;
   
   The required facilities of the above were already added but not enabled yet. 
Will enable and test them in PRs respectively.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to