PHILO-HE commented on code in PR #5070:
URL: https://github.com/apache/incubator-gluten/pull/5070#discussion_r1534966031
##########
gluten-core/src/main/scala/io/glutenproject/expression/ExpressionConverter.scala:
##########
@@ -115,6 +116,16 @@ object ExpressionConverter extends SQLConfHelper with
Logging {
return replaceScalaUDFWithExpressionTransformer(s, attributeSeq,
expressionsMap)
case _ if HiveUDFTransformer.isHiveUDF(expr) =>
return HiveUDFTransformer.replaceWithExpressionTransformer(expr,
attributeSeq)
+ case i: StaticInvoke =>
+ i.functionName match {
+ case "decode" =>
Review Comment:
I feel it may be a bit unsafe by just matching "decode", which is the method
name to be called in the provided static object. Maybe, also check the
staticObject of StaticInvoke is `UrlCodec`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
