PHILO-HE commented on code in PR #4798:
URL: https://github.com/apache/incubator-gluten/pull/4798#discussion_r1534985823
##########
backends-velox/src/test/scala/io/glutenproject/execution/VeloxFunctionsValidateSuite.scala:
##########
@@ -513,6 +513,31 @@ class VeloxFunctionsValidateSuite extends
VeloxWholeStageTransformerSuite {
}
}
+ test("Test make_ym_interval function") {
+ withTempPath {
+ path =>
+ Seq[Tuple2[Integer, Integer]]((1, 0), (-1, 1), (null, 1), (1, null))
+ .toDF("year", "month")
+ .write
+ .parquet(path.getCanonicalPath)
+
+
spark.read.parquet(path.getCanonicalPath).createOrReplaceTempView("make_ym_interval_tbl")
+
+ runQueryAndCompare("select make_ym_interval(year, month) from
make_ym_interval_tbl") {
+ checkOperatorMatch[ProjectExecTransformer]
+ }
+
+ runQueryAndCompare("select make_ym_interval(year) from
make_ym_interval_tbl") {
+ checkOperatorMatch[ProjectExecTransformer]
+ }
+
+ // select make_ym_interval() from make_ym_interval_tbl will be
optimized with fallback.
Review Comment:
Maybe, need to add some handling in `FallbackEmptySchemaRelation` to allow
offloading this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
