marin-ma commented on code in PR #5075:
URL: https://github.com/apache/incubator-gluten/pull/5075#discussion_r1537003020
##########
backends-velox/src/test/scala/io/glutenproject/expression/VeloxUdfSuite.scala:
##########
@@ -82,7 +82,8 @@ class VeloxUdfSuiteLocal extends VeloxUdfSuite {
override val master: String = "local[2]"
override protected def sparkConf: SparkConf = {
super.sparkConf
- .set("spark.gluten.sql.columnar.backend.velox.udfLibraryPaths",
udfLibPath)
+ .set("spark.files", udfLibPath)
+ .set("spark.gluten.sql.columnar.backend.velox.udfLibraryPaths",
"libmyudf.so")
Review Comment:
Please do not hard code "libmyudf.so" here. Use a helper function to extract
the filename from `udfLibPath`. Note the `udfLibPath` can also be a
comma-separated string with multiple paths.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
