WangGuangxin commented on code in PR #5007:
URL: https://github.com/apache/incubator-gluten/pull/5007#discussion_r1538532110
##########
gluten-core/src/main/scala/io/glutenproject/extension/columnar/RewriteTypedImperativeAggregate.scala:
##########
@@ -40,6 +41,38 @@ object RewriteTypedImperativeAggregate extends
Rule[SparkPlan] with PullOutProje
}
}
+ def shouldRewriteForPercentileLikeExpr(ae: AggregateExpression): Boolean = {
+ ae.aggregateFunction match {
+ case _: ApproximatePercentile =>
+ ae.mode match {
+ case Partial | PartialMerge => true
Review Comment:
yeah, it should be removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
