zhztheplayer commented on code in PR #5120:
URL: https://github.com/apache/incubator-gluten/pull/5120#discussion_r1538603244
##########
.github/workflows/velox_docker.yml:
##########
@@ -84,31 +89,41 @@ jobs:
path: ./cpp/build/releases
- name: Setup java and maven
run: |
- apt-get update && \
- apt-get install -y openjdk-8-jdk maven && \
+ if [[ "${{ matrix.java }}" == "17" ]]; then
+ apt-get update && \
+ apt-get install -y openjdk-17-jdk maven
+ else
+ apt-get update && \
+ apt-get install -y openjdk-8-jdk maven
+ fi
apt remove openjdk-11* -y
- name: Build for Spark ${{ matrix.spark }}
run: |
cd $GITHUB_WORKSPACE/ && \
- mvn clean install -P${{ matrix.spark }} -Pbackends-velox -DskipTests
+ mvn clean install -P${{ matrix.spark }} -P${{ matrix.java }}
-Pbackends-velox -DskipTests
- name: Build and run TPCH/DS ${{ matrix.spark }}
run: |
cd $GITHUB_WORKSPACE/tools/gluten-it && \
- mvn clean install -P${{ matrix.spark }} \
+ mvn clean install -P${{ matrix.spark }} -P${{ matrix.java }} \
&& GLUTEN_IT_JVM_ARGS=-Xmx5G sbin/gluten-it.sh queries-compare \
--local --preset=velox --benchmark-type=h --error-on-memleak
--off-heap-size=10g -s=1.0 --threads=16 --iterations=1 \
&& GLUTEN_IT_JVM_ARGS=-Xmx5G sbin/gluten-it.sh queries-compare \
--local --preset=velox --benchmark-type=ds --error-on-memleak
--off-heap-size=10g -s=1.0 --threads=16 --iterations=1
-
- run-tpc-test-centos7:
+ run-tpc-test-centos:
needs: build-native-lib
strategy:
fail-fast: false
matrix:
+ os: ["centos:7", "centos:8"]
spark: ["spark-3.2", "spark-3.3", "spark-3.4", "spark-3.5"]
+ java: ["jdk-8", "jdk-17"]
Review Comment:
> yeah, we can reduce some matrix. How about only test centos8 + ubuntu20.04
?
Sounds good if it's enough. Thanks.
> Is it a good time to drop supporting Spark3.2 ?
It was on the plan to stop supporting 3.2 but looks like it may require for
some time or some discussions to take the action. cc @zhouyuan @weiting-chen
may have more contexts on that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
