zhztheplayer commented on PR #5141: URL: https://github.com/apache/incubator-gluten/pull/5141#issuecomment-2021963407
> Thank you @zhztheplayer for the quick fix. After this pr if there is no c2r, the duplicate keys issue is still existed right ? After the fix is applied we should no longer have any relevant issues on BHJ unless unknown. The issue this PR tried to fix only happened when broadcast exchange is fallen back but bhj is not. Which is a corner case for current Gluten, usually they are both fallen back or both not. Thus ideally we shouldn't have this issue in usual bhj processing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
