loudongfeng commented on code in PR #4812:
URL: https://github.com/apache/incubator-gluten/pull/4812#discussion_r1547052679


##########
backends-clickhouse/src/main/scala/org/apache/gluten/backendsapi/clickhouse/CHListenerApi.scala:
##########
@@ -62,6 +63,21 @@ class CHListenerApi extends ListenerApi with Logging {
         s".local_engine.settings.log_processors_profiles",
       "true")
 
+    // add memory limit for external sort

Review Comment:
   If in memory sort size is not set for SortingStep, then use this formula to 
assign one:
    (executor's OffHeap Memory Size / cores per executors) * 0.8



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to