This is an automated email from the ASF dual-hosted git repository.

philo pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git


The following commit(s) were added to refs/heads/main by this push:
     new 55818ed78 [VL] Enable array_remove Spark function (#5268)
55818ed78 is described below

commit 55818ed7863dd2dc1f213d55eb1d7608303c4e0c
Author: Ankita Victor <[email protected]>
AuthorDate: Wed Apr 3 14:16:14 2024 +0530

    [VL] Enable array_remove Spark function (#5268)
---
 .../src/main/scala/org/apache/gluten/utils/CHExpressionUtil.scala    | 1 +
 .../src/test/scala/org/apache/gluten/execution/TestOperator.scala    | 5 +++++
 .../main/scala/org/apache/gluten/expression/ExpressionMappings.scala | 1 +
 .../main/scala/org/apache/gluten/expression/ExpressionNames.scala    | 1 +
 4 files changed, 8 insertions(+)

diff --git 
a/backends-clickhouse/src/main/scala/org/apache/gluten/utils/CHExpressionUtil.scala
 
b/backends-clickhouse/src/main/scala/org/apache/gluten/utils/CHExpressionUtil.scala
index 96dd71164..d169d9ec5 100644
--- 
a/backends-clickhouse/src/main/scala/org/apache/gluten/utils/CHExpressionUtil.scala
+++ 
b/backends-clickhouse/src/main/scala/org/apache/gluten/utils/CHExpressionUtil.scala
@@ -174,6 +174,7 @@ object CHExpressionUtil {
     ENCODE -> EncodeDecodeValidator(),
     ARRAY_EXCEPT -> DefaultValidator(),
     ARRAY_REPEAT -> DefaultValidator(),
+    ARRAY_REMOVE -> DefaultValidator(),
     DATE_FROM_UNIX_DATE -> DefaultValidator(),
     MONOTONICALLY_INCREASING_ID -> DefaultValidator(),
     SPARK_PARTITION_ID -> DefaultValidator(),
diff --git 
a/backends-velox/src/test/scala/org/apache/gluten/execution/TestOperator.scala 
b/backends-velox/src/test/scala/org/apache/gluten/execution/TestOperator.scala
index 70d7e56c0..ad5e87436 100644
--- 
a/backends-velox/src/test/scala/org/apache/gluten/execution/TestOperator.scala
+++ 
b/backends-velox/src/test/scala/org/apache/gluten/execution/TestOperator.scala
@@ -766,6 +766,11 @@ class TestOperator extends VeloxWholeStageTransformerSuite 
{
                            |""".stripMargin) {
         checkGlutenOperatorMatch[ProjectExecTransformer]
       }
+      runQueryAndCompare("""
+                           |SELECT array_remove(c1, 3) FROM t;
+                           |""".stripMargin) {
+        checkGlutenOperatorMatch[ProjectExecTransformer]
+      }
     }
   }
 
diff --git 
a/gluten-core/src/main/scala/org/apache/gluten/expression/ExpressionMappings.scala
 
b/gluten-core/src/main/scala/org/apache/gluten/expression/ExpressionMappings.scala
index 768df4783..8a2201930 100644
--- 
a/gluten-core/src/main/scala/org/apache/gluten/expression/ExpressionMappings.scala
+++ 
b/gluten-core/src/main/scala/org/apache/gluten/expression/ExpressionMappings.scala
@@ -225,6 +225,7 @@ object ExpressionMappings {
     Sig[GetArrayStructFields](GET_ARRAY_STRUCT_FIELDS),
     Sig[ArrayExcept](ARRAY_EXCEPT),
     Sig[ArrayRepeat](ARRAY_REPEAT),
+    Sig[ArrayRemove](ARRAY_REMOVE),
     // Map functions
     Sig[CreateMap](CREATE_MAP),
     Sig[GetMapValue](GET_MAP_VALUE),
diff --git 
a/shims/common/src/main/scala/org/apache/gluten/expression/ExpressionNames.scala
 
b/shims/common/src/main/scala/org/apache/gluten/expression/ExpressionNames.scala
index dc1fd3733..6206db3f2 100644
--- 
a/shims/common/src/main/scala/org/apache/gluten/expression/ExpressionNames.scala
+++ 
b/shims/common/src/main/scala/org/apache/gluten/expression/ExpressionNames.scala
@@ -238,6 +238,7 @@ object ExpressionNames {
   final val GET_ARRAY_STRUCT_FIELDS = "get_array_struct_fields"
   final val ARRAY_EXCEPT = "array_except"
   final val ARRAY_REPEAT = "array_repeat"
+  final val ARRAY_REMOVE = "array_remove"
 
   // Map functions
   final val CREATE_MAP = "map"


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to