Yohahaha commented on code in PR #5321:
URL: https://github.com/apache/incubator-gluten/pull/5321#discussion_r1555835707
##########
gluten-core/src/main/scala/org/apache/gluten/backendsapi/IteratorApi.scala:
##########
@@ -91,4 +91,6 @@ trait IteratorApi {
numOutputRows: SQLMetric,
numOutputBatches: SQLMetric,
scanTime: SQLMetric): RDD[ColumnarBatch]
+
+ def toLocalFilesNodeByteArray(p: GlutenRawPartition): Array[Array[Byte]]
Review Comment:
could we add a new SplitInfo object file and move this method into it with
`toSplitInfoByteArray`? then other backends could use it more easily, and avoid
add this method in `IteratorApi` which seems unrelated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
