This is an automated email from the ASF dual-hosted git repository.

philo pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git


The following commit(s) were added to refs/heads/main by this push:
     new 0560ddd7b [GLUTEN-5316][CORE] Add @Override annotation for some 
methods (#5317)
0560ddd7b is described below

commit 0560ddd7b2b04a6f435de4b8bdd802396b984e4f
Author: Qian Sun <[email protected]>
AuthorDate: Tue Apr 9 08:55:55 2024 +0800

    [GLUTEN-5316][CORE] Add @Override annotation for some methods (#5317)
---
 .../main/java/org/apache/gluten/memory/memtarget/TreeMemoryTargets.java  | 1 +
 .../main/java/org/apache/gluten/substrait/rel/ExtensionTableNode.java    | 1 +
 .../src/main/java/org/apache/gluten/substrait/rel/LocalFilesNode.java    | 1 +
 .../java/org/apache/gluten/vectorized/ArrowWritableColumnVector.java     | 1 +
 4 files changed, 4 insertions(+)

diff --git 
a/gluten-core/src/main/java/org/apache/gluten/memory/memtarget/TreeMemoryTargets.java
 
b/gluten-core/src/main/java/org/apache/gluten/memory/memtarget/TreeMemoryTargets.java
index 9566e11a5..a8dc39ce3 100644
--- 
a/gluten-core/src/main/java/org/apache/gluten/memory/memtarget/TreeMemoryTargets.java
+++ 
b/gluten-core/src/main/java/org/apache/gluten/memory/memtarget/TreeMemoryTargets.java
@@ -139,6 +139,7 @@ public class TreeMemoryTargets {
       return granted;
     }
 
+    @Override
     public List<Spiller> getNodeSpillers() {
       return spillers;
     }
diff --git 
a/gluten-core/src/main/java/org/apache/gluten/substrait/rel/ExtensionTableNode.java
 
b/gluten-core/src/main/java/org/apache/gluten/substrait/rel/ExtensionTableNode.java
index 8da97fa12..f5cfd1da5 100644
--- 
a/gluten-core/src/main/java/org/apache/gluten/substrait/rel/ExtensionTableNode.java
+++ 
b/gluten-core/src/main/java/org/apache/gluten/substrait/rel/ExtensionTableNode.java
@@ -177,6 +177,7 @@ public class ExtensionTableNode implements SplitInfo {
     return this.preferredLocations;
   }
 
+  @Override
   public ReadRel.ExtensionTable toProtobuf() {
     ReadRel.ExtensionTable.Builder extensionTableBuilder = 
ReadRel.ExtensionTable.newBuilder();
     StringValue extensionTable =
diff --git 
a/gluten-core/src/main/java/org/apache/gluten/substrait/rel/LocalFilesNode.java 
b/gluten-core/src/main/java/org/apache/gluten/substrait/rel/LocalFilesNode.java
index 428266b73..cbcda72dd 100644
--- 
a/gluten-core/src/main/java/org/apache/gluten/substrait/rel/LocalFilesNode.java
+++ 
b/gluten-core/src/main/java/org/apache/gluten/substrait/rel/LocalFilesNode.java
@@ -120,6 +120,7 @@ public class LocalFilesNode implements SplitInfo {
   protected void processFileBuilder(
       ReadRel.LocalFiles.FileOrFiles.Builder fileBuilder, int index) {}
 
+  @Override
   public ReadRel.LocalFiles toProtobuf() {
     ReadRel.LocalFiles.Builder localFilesBuilder = 
ReadRel.LocalFiles.newBuilder();
     // The input is iterator, and the path is in the format of: Iterator:index.
diff --git 
a/gluten-data/src/main/java/org/apache/gluten/vectorized/ArrowWritableColumnVector.java
 
b/gluten-data/src/main/java/org/apache/gluten/vectorized/ArrowWritableColumnVector.java
index 3b1049fca..4603cbc41 100644
--- 
a/gluten-data/src/main/java/org/apache/gluten/vectorized/ArrowWritableColumnVector.java
+++ 
b/gluten-data/src/main/java/org/apache/gluten/vectorized/ArrowWritableColumnVector.java
@@ -558,6 +558,7 @@ public final class ArrowWritableColumnVector extends 
WritableColumnVectorShim {
    * Returns the dictionary Id for rowId. This should only be called when the 
ColumnVector is
    * dictionaryIds. We have this separate method for dictionaryIds as per 
SPARK-16928.
    */
+  @Override
   public int getDictId(int rowId) {
     assert (dictionary == null);
     return accessor.getInt(rowId);


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to