summaryzb commented on code in PR #3767:
URL: https://github.com/apache/incubator-gluten/pull/3767#discussion_r1556740563
##########
cpp/core/jni/JniWrapper.cc:
##########
@@ -915,6 +915,23 @@ JNIEXPORT jlong JNICALL
Java_org_apache_gluten_vectorized_ShuffleWriterJniWrappe
std::move(partitionWriterOptions),
memoryManager->getArrowMemoryPool(),
std::move(celebornClient));
+ } else if (partitionWriterType == "uniffle") {
+ jclass unifflePartitionPusherClass =
+ createGlobalClassReferenceOrError(env,
"Lorg/apache/spark/shuffle/writer/PartitionPusher;");
+ jmethodID unifflePushPartitionDataMethod =
+ getMethodIdOrError(env, unifflePartitionPusherClass,
"pushPartitionData", "(I[BI)I");
+ JavaVM* vm;
+ if (env->GetJavaVM(&vm) != JNI_OK) {
+ throw gluten::GlutenException("Unable to get JavaVM instance");
+ }
+ // rename CelebornClient RssClient
+ std::shared_ptr<CelebornClient> uniffleClient =
+ std::make_shared<CelebornClient>(vm, partitionPusher,
unifflePushPartitionDataMethod);
+ partitionWriter = std::make_unique<CelebornPartitionWriter>(
Review Comment:
Using a common name relate to all the logic of rss in jni layer, but not
limit to this `PartitionWriter`, maybe it's better to resolve this in a
separate pr
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
