zwangsheng commented on PR #5367: URL: https://github.com/apache/incubator-gluten/pull/5367#issuecomment-2049214173
> @zwangsheng It feels messy that golden files are being considered into PR/contribution line count. Do you think we can binarize the golden files? > Sounds good to me, we don't care about the specific storage format, as long as it's good enough for valid comparisons during unit testing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
