Yohahaha commented on PR #5202: URL: https://github.com/apache/incubator-gluten/pull/5202#issuecomment-2049330517
> > Hi, could you share the current status? > > @Yohahaha, this pr depends on a velox pr: [facebookincubator/velox#9425](https://github.com/facebookincubator/velox/pull/9425). I will try to push the review progress. why not choose below usage? I think velox has already support register with prefix, the only thing we need to do is choose which prefixed-function is gluten needed. correct me if it's wrong, thank you! ``` velox::functions::prestosql::registerAllScalarFunctions("presto_"); velox::functions::sparksql::registerFunctions("spark_"); prestoMap("array_distinct" -> "presto"); // do naming conversion in cpp module ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
