This is an automated email from the ASF dual-hosted git repository.
changchen pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git
The following commit(s) were added to refs/heads/main by this push:
new a06a2fdc8 fix ut due to
https://github.com/ClickHouse/ClickHouse/pull/61216 (#5388)
a06a2fdc8 is described below
commit a06a2fdc8d9ef33ca6024c78f0ad7914995f80c8
Author: Chang chen <[email protected]>
AuthorDate: Fri Apr 12 22:21:03 2024 +0800
fix ut due to https://github.com/ClickHouse/ClickHouse/pull/61216 (#5388)
---
cpp-ch/local-engine/Parser/JoinRelParser.cpp | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/cpp-ch/local-engine/Parser/JoinRelParser.cpp
b/cpp-ch/local-engine/Parser/JoinRelParser.cpp
index f02a10b11..023a51552 100644
--- a/cpp-ch/local-engine/Parser/JoinRelParser.cpp
+++ b/cpp-ch/local-engine/Parser/JoinRelParser.cpp
@@ -286,8 +286,16 @@ DB::QueryPlanPtr JoinRelParser::parseJoin(const
substrait::JoinRel & join, DB::Q
void JoinRelParser::addConvertStep(TableJoin & table_join, DB::QueryPlan &
left, DB::QueryPlan & right)
{
+
+ /// After https://github.com/ClickHouse/ClickHouse/pull/61216, We will
failed at tryPushDownFilter() in filterPushDown.cpp
+ /// Here is a workaround, refer to chooseJoinAlgorithm() in
PlannerJoins.cpp, it always call TableJoin::setRename to
+ /// create aliases for columns in the right table
+ /// By using right table header name sets, so
TableJoin::deduplicateAndQualifyColumnNames can do same thing as
chooseJoinAlgorithm()
+ ///
+ /// Affected UT fixed bh this workaround:
+ /// GlutenClickHouseTPCHParquetRFSuite:TPCH Q17, Q19, Q20, Q21
NameSet left_columns_set;
- for (const auto & col : left.getCurrentDataStream().header.getNames())
+ for (const auto & col : right.getCurrentDataStream().header.getNames())
{
left_columns_set.emplace(col);
}
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
