kerwin-zk commented on code in PR #5385:
URL: https://github.com/apache/incubator-gluten/pull/5385#discussion_r1565118115
##########
cpp/core/jni/JniCommon.h:
##########
@@ -452,17 +452,16 @@ class CelebornClient : public RssClient {
array_ = static_cast<jbyteArray>(env->NewGlobalRef(array_));
}
env->SetByteArrayRegion(array_, 0, size, reinterpret_cast<jbyte*>(bytes));
- jint celebornBytesSize =
- env->CallIntMethod(javaCelebornShuffleWriter_,
javaCelebornPushPartitionData_, partitionId, array_, size);
+ jint javaBytesSize = env->CallIntMethod(javaShuffleWriter_,
javaPushPartitionData_, partitionId, array_, size);
checkException(env);
- return static_cast<int32_t>(celebornBytesSize);
+ return static_cast<int32_t>(javaBytesSize);
}
void stop() override {}
private:
JavaVM* vm_;
- jobject javaCelebornShuffleWriter_;
- jmethodID javaCelebornPushPartitionData_;
+ jobject javaShuffleWriter_;
Review Comment:
javaShuffleWriter_ -> javaRssShuffleWriter_
##########
cpp/core/jni/JniCommon.h:
##########
@@ -411,28 +411,28 @@ class BacktraceAllocationListener final : public
gluten::AllocationListener {
std::atomic_int64_t backtraceBytes_{1L << 30};
};
-class CelebornClient : public RssClient {
+class JavaRssClient : public RssClient {
public:
- CelebornClient(JavaVM* vm, jobject javaCelebornShuffleWriter, jmethodID
javaCelebornPushPartitionDataMethod)
- : vm_(vm),
javaCelebornPushPartitionData_(javaCelebornPushPartitionDataMethod) {
+ JavaRssClient(JavaVM* vm, jobject javaShuffleWriter, jmethodID
javaPushPartitionDataMethod)
Review Comment:
javaShuffleWriter -> javaRssShuffleWriter
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
