guixiaowen commented on PR #5266: URL: https://github.com/apache/incubator-gluten/pull/5266#issuecomment-2055688155
> > @ulysses-you I noticed that there is an existing [PR](https://github.com/apache/incubator-gluten/pull/5269) about collect limit support but may have some different coverage. You may can take a look to avoid some duplicated work. FYI. > > Seems to be that this PR was opened a little bit earlier than #5269. > > So @ulysses-you @guixiaowen thank both of you for taking this part of work. Do you think we should decide using which PR before continuing on this? @zhztheplayer @ulysses-you hi both, I'm very sorry for not paying attention to this review. I replied a bit late. I mentioned issues before and didn't notice that @ulysses-you had already been submitted before me. If the evaluation criteria were based on the order of submission, @ulysses-you's should be used. @zhztheplayer Thank you for your review. I will close my pr later. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
