zhztheplayer commented on code in PR #5409:
URL: https://github.com/apache/incubator-gluten/pull/5409#discussion_r1566886568
##########
gluten-core/src/main/resources/substrait/proto/substrait/algebra.proto:
##########
@@ -268,6 +268,15 @@ message FetchRel {
substrait.extensions.AdvancedExtension advanced_extension = 10;
}
+// The relational operator representing TOP N calculation
+message TopNRel {
+ RelCommon common = 1;
+ Rel input = 2;
+ int64 n = 3;
+ repeated SortField sorts = 4;
+ substrait.extensions.AdvancedExtension advanced_extension = 10;
+}
Review Comment:
Refer to this comment
https://github.com/apache/incubator-gluten/pull/5409#discussion_r1566884037,
let's make a new operator for better compatibility with other potential
Substrait implementers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
