marin-ma commented on code in PR #5442:
URL: https://github.com/apache/incubator-gluten/pull/5442#discussion_r1569912522
##########
backends-velox/src/main/scala/org/apache/gluten/backendsapi/velox/VeloxBackend.scala:
##########
@@ -481,10 +481,10 @@ object BackendSettings extends BackendSettingsApi {
private def checkMaxBatchSize(nativeConf: java.util.Map[String, String]):
Unit = {
if (nativeConf.containsKey(GlutenConfig.GLUTEN_MAX_BATCH_SIZE_KEY)) {
val maxBatchSize =
nativeConf.get(GlutenConfig.GLUTEN_MAX_BATCH_SIZE_KEY).toInt
- if (maxBatchSize > MAXIMUM_BATCH_SIZE) {
+ if (maxBatchSize >= MAXIMUM_BATCH_SIZE) {
Review Comment:
The check in native shuffle writer requires the split buffer (aka. output
batch size from shuffle writer) <= 32k, which means the maximum batch size in
the pipeline can equal to 32k. But this change makes the maximum batch size <
32k.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
