Yohahaha commented on code in PR #5449:
URL: https://github.com/apache/incubator-gluten/pull/5449#discussion_r1570335030
##########
dev/builddeps-veloxbe.sh:
##########
@@ -189,7 +189,7 @@ function build_velox {
function build_gluten_cpp {
echo "Start to Gluten CPP"
cd $GLUTEN_DIR/cpp
- rm -rf build
+ sudo rm -rf build
mkdir build
cd build
Review Comment:
do we really need this change? if you need sudo rm, you will need sudo mkdir
too, could you double check it?
##########
ep/build-velox/src/build_velox.sh:
##########
@@ -209,7 +209,7 @@ function check_commit {
fi
else
# Branch-new build requires all untracked files to be deleted. We only
need the source code.
- git clean -dffx :/
+ sudo git clean -dffx :/
Review Comment:
great catch!
##########
dev/builddeps-veloxbe.sh:
##########
@@ -213,4 +213,4 @@ commands_to_run=${OTHER_ARGUMENTS:-}
"${cmd}"
done
fi
-)
\ No newline at end of file
+)
Review Comment:
just avoid introducing unnecessary changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
