liujiayi771 commented on code in PR #5444:
URL: https://github.com/apache/incubator-gluten/pull/5444#discussion_r1571713055
##########
backends-velox/src/test/scala/org/apache/gluten/execution/VeloxAggregateFunctionsSuite.scala:
##########
@@ -432,14 +432,46 @@ abstract class VeloxAggregateFunctionsSuite extends
VeloxWholeStageTransformerSu
}
// Disable for Sparke3.5.
- testWithSpecifiedSparkVersion("regr_sxy", Some("3.4"), Some("3.4")) {
+ testWithSpecifiedSparkVersion("regr_sxy regr_sxx regr_syy", Some("3.4"),
Some("3.4")) {
Review Comment:
I think the problem is that `Spark35Shims` not add these regr functions to
`aggregateExpressionMappings`. I will add them all in another PR. Including
regr_r2, repr_slope, regr_intercpt, and so on.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
