yma11 commented on code in PR #5445:
URL: https://github.com/apache/incubator-gluten/pull/5445#discussion_r1571748318
##########
backends-velox/src/test/scala/org/apache/gluten/execution/VeloxHashJoinSuite.scala:
##########
@@ -88,6 +87,8 @@ class VeloxHashJoinSuite extends
VeloxWholeStageTransformerSuite {
val wholeStages = plan.collect { case wst: WholeStageTransformer => wst }
if (SparkShimLoader.getSparkVersion.startsWith("3.2.")) {
assert(wholeStages.length == 1)
+ } else if (SparkShimLoader.getSparkVersion.startsWith("3.5.")) {
Review Comment:
@ayushi-agarwal Do you want to further dig out the plan change? if so, you
can open a ticket dedicated for it. Maybe related with data set or some
setting. Let's merge this PR first.
##########
backends-velox/src/test/scala/org/apache/gluten/execution/VeloxHashJoinSuite.scala:
##########
@@ -88,6 +87,8 @@ class VeloxHashJoinSuite extends
VeloxWholeStageTransformerSuite {
val wholeStages = plan.collect { case wst: WholeStageTransformer => wst }
if (SparkShimLoader.getSparkVersion.startsWith("3.2.")) {
assert(wholeStages.length == 1)
+ } else if (SparkShimLoader.getSparkVersion.startsWith("3.5.")) {
Review Comment:
@ayushi-agarwal Do you want to further dig out the plan change? if so, you
can open a ticket dedicated for it. Maybe related with data set or some
configurations. Let's merge this PR first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
